implement horizontal scrolling with trackpad to windows (and bring ba…#666
Open
implement horizontal scrolling with trackpad to windows (and bring ba…#666
Conversation
Owner
|
This prolly doesn't apply on 2.208 anymore does it? |
Cvolton
suggested changes
Feb 19, 2026
| class $modify(MouseScrollWindowsFix, CCEGLView){ | ||
| static void onModify(auto& self) { | ||
| // The static version inlines the actual callback, so i uninline it by hooking it | ||
| (void)Mod::get()->hook((void*)(base::getCocos() + 0x76390), &MouseScrollWindowsFix::onGLFWMouseScrollCallbackStatic, "onGLFWMouseScrollCallbackStatic"); |
Contributor
There was a problem hiding this comment.
i think this wont work on 2.207 but im not sure............
| return static_cast<MouseScrollWindowsFix*>(CCEGLView::get()); | ||
| } | ||
|
|
||
| // |
Contributor
There was a problem hiding this comment.
this is a good comment i like it
yes im a qualified betteredit reviewer official now
Contributor
There was a problem hiding this comment.
this is a good comment i like it yes im a qualified betteredit reviewer official now
this is a good review comment i like it
i'm not a qualified betteredit reviewer unofficial real
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ck macos)