Skip to content

Quality of life improvements#30

Open
tdealtry wants to merge 11 commits intoHKDAQ:masterfrom
tdealtry:better_defaults
Open

Quality of life improvements#30
tdealtry wants to merge 11 commits intoHKDAQ:masterfrom
tdealtry:better_defaults

Conversation

@tdealtry
Copy link
Collaborator

@tdealtry tdealtry commented Mar 4, 2024

  • Make detector a required argument of flower_with_bonsai.C
  • New option to get NPMTs from WCSimRootGeom
  • Default option to get PMT dark rate from WCSimRootOptions (can override with macro argument)
  • New CheckNearestNeighbours() method for testing distances in new geometries
  • Ensure the nearest neighbours file you're reading in has the right number of PMTs in it
  • Add way to get fNEff & fNEff2 (required for tuning)
  • Add new enumeration for new HK detector geometry (tune will come in a new PR)
  • flower_with_bonsai.C now produces a TTree with reconstruction results
  • flower_with_bonsai.C safely handles BONSAI exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant