Fix: Fucking Windows may force working directory to system32 for unknown reasons. #4847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavo
reviewed
Dec 11, 2025
| if (path != null) { | ||
| Path parent = path.getParent(); | ||
| if (parent != null) { | ||
| System.setProperty("user.dir", parent.toAbsolutePath().toString()); |
Member
Author
There was a problem hiding this comment.
现版本的 HMCL 会因为无法创建 .hmcl 文件夹而直接拒绝启动
Member
There was a problem hiding this comment.
现版本的 HMCL 会因为无法创建 .hmcl 文件夹而直接拒绝启动
直接拒绝启动也比出现一大堆微妙的问题更好。
这个 PR 非常明显的不能正常工作。比如 Metadata 比你这段代码更早初始化，你设置 user.dir 的时候 Metadata.CURRENT_DIRECTORY 早就初始化完了，很多地方都不会遵循你这里新设置的路径。而且我怀疑有更多位置的代码可能无法遵循这里设置的路径。
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.