Fix code quality: resolve 209 linting errors, add type hints, fix YAML/template bugs#1
Draft
Copilot wants to merge 4 commits into002-simplify-teaching-flowfrom
Draft
Fix code quality: resolve 209 linting errors, add type hints, fix YAML/template bugs#1Copilot wants to merge 4 commits into002-simplify-teaching-flowfrom
Copilot wants to merge 4 commits into002-simplify-teaching-flowfrom
Conversation
- Update pyproject.toml to use modern ruff lint configuration - Fix 209 linting errors (import sorting, whitespace) - Fix YAML indentation in default config template - Split long console.print lines to meet 100-char limit - Remove trailing whitespace from all files Co-authored-by: Haaaiawd <129919749+Haaaiawd@users.noreply.github.com>
- Add return type annotations to all functions - Fix inconsistency between required_templates and allowed_templates - Improve code maintainability and type safety Co-authored-by: Haaaiawd <129919749+Haaaiawd@users.noreply.github.com>
- Add return type annotations to all command functions - Add proper type hints to utility functions - Import necessary types (Union, Generator) - Improve code type safety and IDE support Co-authored-by: Haaaiawd <129919749+Haaaiawd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review and optimize existing codebase for performance
Fix code quality: resolve 209 linting errors, add type hints, fix YAML/template bugs
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codebase audit requested ("看看有撒能优化的没" - "see what can be optimized"). Found and fixed linting violations, missing type annotations, and two bugs.
Changes
Code Quality (209 issues)
pyproject.tomlto modern ruff lint configuration formatType Safety (29+ functions)
Union,Generator,Optional)Bug Fixes
logging.filekey in default config template (was indented 4 spaces instead of 2)required_templateslist (referencedteaching-prompt-template.md) andallowed_templatesset (didn't include it)Security
CodeQL scan: 0 alerts
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.