VladN-week1-Database #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
requested changes
Aug 30, 2025
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
Hi Vlad,
Overall it is a great job. I can see you are exploring more advanced concepts 👍
I have made the points that need rework explicit. I also left some comments just for improvements.
Please ping me on Slack when you finish rework. If you have any questions, don't hesitate to contact me on Slack. Have a nice weekend!
yunchen4
approved these changes
Sep 5, 2025
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
LGTM, just a small suggestion for code readability.
Comment on lines
+18
to
+19
| let admin; // reference to admin client | ||
| let db; // reference to meetup client |
There was a problem hiding this comment.
You can consider using just one instance of Client and do something like:
client.end();
client.database = "meetup";
client.connect();
This way the code will be more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.