Improvements to file select menu#650
Open
ashifolfi wants to merge 2 commits intoHackerN64:develop/3.0.0from
Open
Improvements to file select menu#650ashifolfi wants to merge 2 commits intoHackerN64:develop/3.0.0from
ashifolfi wants to merge 2 commits intoHackerN64:develop/3.0.0from
Conversation
- Save file, save info, and lower button positions are now in arrays - Main menu button positions are now determined by submenu positions (multiplication) - copy menu button duplication bug fixed (typo in `load_menu_from_submenu`) - status message storage glitch fixed (`sStatusMessageID` is reset on submenu change) - all file info print instances are replaced with a call to a function to print - modified `sCursorClickingTimer` to count down instead of up
thecozies
added
documentation
Collaborator
|
Someone needs to fix conflicts here and also check that it looks the same as vanilla. Otherwise am happy to approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_menu_from_submenu)sStatusMessageIDis reset on submenu change)sCursorClickingTimerto count down instead of upThese changes make the file select menu less painful to modify for those wanting to adjust the layout while still providing a nearly if not identical menu for those who aren't looking to modify the file select menu.
Any additional edits or improvements are welcomed and encouraged.