3.0 - Microcode overhaul#816
Conversation
|
if ex3 is still subject to changes then shouldn't this go into it's own |
Probably not, it'll cause mayhem with disconnected feature branches if we have two split major branches (sporting a 2.4 branch for smaller changes is already painful enough) |
|
ready |
7f666f2 to
da9c5ca
Compare
|
rundown to people just now reviewing:
bonuses:
|
|
im arthurtilly and i approve this pr |
|
it is time to review #816 |
1 similar comment
|
it is time to review #816 |
| * This feature is not available for use with F3DEX3. | ||
| */ | ||
|
|
||
| // #define ENABLE_LINE_UCODE |
There was a problem hiding this comment.
Hmm, is there any legitimate reason to not just ship this by default with EX2?
There was a problem hiding this comment.
I mean it would be an extra 8 KB of RAM wasted
There was a problem hiding this comment.
But is 8kb really worth an entire config define? That's 2 textures.
There was a problem hiding this comment.
why is this not just in the makefile isnt that where it was before
|
fixed |
The goal of this is to combine #789 and #764, while also moving microcode config from the makefile to config_graphics.h