Wrapper class to fix BUrl compatibility issues - #71
Closed
pulkomandy wants to merge 1 commit into
Closed
Conversation
Contributor
|
Aren't these different use cases? Homepage vs stream consuming? |
|
FWIW, this builds fine now on hrev59899 x86_32. (tried with the HaikuPorts StreamRadio .recipe, updated to the latest srcGitRev, and applying this PR as .patchset). Builds fine, but I don't seem able to find any stations (it does shows "Connected to server: https://91.98.4.78/" in the Terminal output). Hitting the "globe" button next to the "Service [ Comuniti Radio Browser ]" in the Find stations dialog, shows a Terminal that reads: (no Web+ or other browser installed at the moment :-/) Trying to paste a station URL (that I've got from that radio-browser.info website), seems to do nothing, |
Member
Author
|
The wrapper class becomes unnecessary now, as beta 6 is released. StreamRadio can be adjused to work with (only) the new API
|
Contributor
|
Switch to the new API in 6824813 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested fix for #70
@korli do you think this approach is OK to enclose source compatibility issues in a single class? It also makes sure the URL is encoded in the same way on all versions, so that should avoid unexpected changes of behavior.
Note: I wrote this in a train with spotty internet connection and I have no soundcard on this Haiku machine, so this is not fully tested.