Support for multiple accounts and service account authentication#18
Support for multiple accounts and service account authentication#18aschempp wants to merge 10 commits intoHappyr:masterfrom
Conversation
aschempp
force-pushed
the
feature/clients
branch
from
82ee6ff to
af1275d
Compare
|
As promised, v2 tested and works as expected 😎 |
|
Any update on this PR ? |
|
Nice work, thanks @aschempp |
|
will this get merged somewhen? |
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
It's quite a large change and no tests.
Im happy you are using this bundle. What do you say if we merge this and tag 3.0?
Could you rebase this and then write a entry in the changelog?
| * {@inheritDoc} | ||
| */ | ||
| public function load(array $configs, ContainerBuilder $container) | ||
| public function loadInternal(array $config, ContainerBuilder $container) |
There was a problem hiding this comment.
The ConfigurableExtension is just a shortcut with helper methods.
The changes are supposed to be backwards compatible, so there's no need for v3 from my side. As you can see, it has been a while (Aug 2016) when I implemented this. I'm still actively using that fork, but I'd love to see this in the core. What would you say if I create separate branches and pull requests for the separate features? I can also look at the unit tests in that case. Or would you say its too much work to review every detail and just get a 3.0 out? |
* Add symfony 4 compatibility * Remove useless compatibility for symfony/yaml (cherry picked from commit 9238275)
|
Sorry for the delay. I will create separate PRs as soon as I can find some time. I'm still actively using that feature, so I won't forget about it. |
|
#SymfonyHackday |
6 participants
This PR adds two features:
Use e.g.
happyr.google.api.default_analyticsandhappyr.google.api.special_youtubewith different credentials.Everything should be fully BC with existing version (automatically converting the bundle configuration). I have been using the service authentication with client v1 for over a year now, it works well. I just added client v2 now and will test that implementation soon.
Let me know what you think :-)