move speed modifier settings to cheats#6277
Merged
serprex merged 4 commits intoHarbourMasters:developfrom Mar 2, 2026
Merged
Conversation
Member
Author
|
@aMannus let me know if this UI looks good, then can add migration code to make moved cvars cheats |
Malkierian
approved these changes
Mar 1, 2026
Contributor
Malkierian
left a comment
There was a problem hiding this comment.
UI looks fine, though it's weird those checkboxes are wrapping text like that. Not your issue, though.
255b2ec to
0dc7793
Compare
Member
Author
|
Taking advice from @garrettjoecox & reducing to one speed modifier |
13fd816 to
1fb4c66
Compare
serprex
commented
Mar 2, 2026
1fb4c66 to
ff35462
Compare
Member
Author
|
@Malkierian this PR evolved a lot since you reviewed, both in UI (discussion suggested 1 slider), & config migration |
Contributor
|
Member
Author
|
switched away from |
Contributor
|
Hmm. Alright, seems Google says storing and checking nullptr there is standard, so we can keep it. |
89ce059 to
47ceb90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
left configuring modifier buttons on controls pane
fixes #5326
Build Artifacts