Skip to content

move speed modifier settings to cheats#6277

Merged
serprex merged 4 commits intoHarbourMasters:developfrom
serprex:speed-modifiers-are-cheating
Mar 2, 2026
Merged

move speed modifier settings to cheats#6277
serprex merged 4 commits intoHarbourMasters:developfrom
serprex:speed-modifiers-are-cheating

Conversation

@serprex
Copy link
Copy Markdown
Member

@serprex serprex commented Feb 16, 2026

left configuring modifier buttons on controls pane

fixes #5326

Build Artifacts

@serprex serprex requested a review from aMannus February 16, 2026 23:04
@serprex
Copy link
Copy Markdown
Member Author

serprex commented Feb 16, 2026

@aMannus let me know if this UI looks good, then can add migration code to make moved cvars cheats

@serprex serprex marked this pull request as draft February 16, 2026 23:06
Copy link
Copy Markdown
Contributor

@Malkierian Malkierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks fine, though it's weird those checkboxes are wrapping text like that. Not your issue, though.

@serprex serprex requested a review from garrettjoecox March 2, 2026 01:44
@serprex serprex force-pushed the speed-modifiers-are-cheating branch from 255b2ec to 0dc7793 Compare March 2, 2026 02:24
@serprex serprex marked this pull request as ready for review March 2, 2026 02:25
@serprex
Copy link
Copy Markdown
Member Author

serprex commented Mar 2, 2026

Taking advice from @garrettjoecox & reducing to one speed modifier

@serprex serprex force-pushed the speed-modifiers-are-cheating branch 2 times, most recently from 13fd816 to 1fb4c66 Compare March 2, 2026 02:39
Comment thread soh/soh/config/ConfigMigrators.h
@serprex serprex force-pushed the speed-modifiers-are-cheating branch from 1fb4c66 to ff35462 Compare March 2, 2026 02:48
@serprex serprex requested a review from Malkierian March 2, 2026 16:17
@serprex
Copy link
Copy Markdown
Member Author

serprex commented Mar 2, 2026

@Malkierian this PR evolved a lot since you reviewed, both in UI (discussion suggested 1 slider), & config migration

@Malkierian
Copy link
Copy Markdown
Contributor

Malkierian commented Mar 2, 2026

  1. If you're going to remove the use of MigrationAction in the Migration struct, might as well kill the MigrationAction struct.
  2. I'd suggest still using std::string, using empty strings (""), and checking for empty for removal vs renaming. I'm not sure I like the idea of nullptr associated with const char*.

@serprex
Copy link
Copy Markdown
Member Author

serprex commented Mar 2, 2026

switched away from std::string since we're only calling c_str on them, figured best for data model to match destination interface

@Malkierian
Copy link
Copy Markdown
Contributor

Hmm. Alright, seems Google says storing and checking nullptr there is standard, so we can keep it.

@serprex serprex force-pushed the speed-modifiers-are-cheating branch from 89ce059 to 47ceb90 Compare March 2, 2026 17:16
@serprex serprex merged commit 2a335b1 into HarbourMasters:develop Mar 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Walk/swim speed modifiers should be under cheats

2 participants