Skip to content

fix(postprocess): use Src map for T1 node lookup in FilterPunctuation - #41

Merged
HarshK97 merged 1 commit into
mainfrom
fix/punctuation-split-mapping
Aug 1, 2026
Merged

fix(postprocess): use Src map for T1 node lookup in FilterPunctuation#41
HarshK97 merged 1 commit into
mainfrom
fix/punctuation-split-mapping

Conversation

@HarshK97

@HarshK97 HarshK97 commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Problem

  1. When splitting punctuation move or update actions into delete and insert steps, the filter looked up the source node in ms.Dst().
  2. ms.Dst() maps destination nodes to source nodes, so querying it with a source node returned nil. So the insert action for destination punctuation got silently dropped.

What Changed

  • Punctuation Filtering: Fixed the map lookup in FilterPunctuation to use ms.Src(), so source nodes properly map to their destination counterparts and the insert action gets added.
  • Unit Tests: Added tests covering strict punctuation move splitting, comma/semicolon filtering, and nil script handling.

@HarshK97
HarshK97 merged commit 2c115c9 into main Aug 1, 2026
6 checks passed
@HarshK97
HarshK97 deleted the fix/punctuation-split-mapping branch August 1, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant