New option data and some minor bugfixes#12
Open
baxeico wants to merge 6 commits intoHawkers:masterfrom
Open
Conversation
added 6 commits
September 10, 2013 16:18
…rily in a hidden field
…ers only the last will work
… position accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a project I need to have in Javascript the ids of users mentioned, but not the message with mentions in the form of @[1234], so I added the option data to make the plugin put id_map in the elem.data() (via jQuery).
Also I fixed a little bug when you have multiple @ in the textarea, only the last @ worked as expected.
Finally I fixed another minor bug where a space was always inserted after the selection, even when not needed.