Bugfix/fix dangling db connection in pgvectorquery #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to connect to database. Added initial tests for components/embeddings.py file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The class
PGVectorQueryincomponents/embeddings.pytakes an openSQLAlchemyconnection.Best practice is to open and close these connections as needed for given hit of the database.
I have removed this as a constructor parameter
connectionand instead used theget_sessioncontext manager fromdb_managerwithin therunmethod ofPGVectorQuery.Related Issues or other material
Related #
Closes #
✅ Added/updated tests?
tests/integration/test_embeddings_db.pyfile with a couple of initial tests for thePGVectorQueryclass andEmbeddingsclass