RND-1911 + GEN-5257: Puppy guide kmp

.github/workflows/staging.yml

@@ -4,6 +4,7 @@ on:
     branches:
       - develop
       - feat/manual-charge
+      - feat/puppy-guide-kmp
   workflow_dispatch:
 
 concurrency:

.github/workflows/umbrella.yml

@@ -4,11 +4,8 @@ on:
   push:
     branches:
       - develop
-      - makerdays/chat-claim
-    paths:
-      - 'app/authlib/**'
-      - 'app/feature/feature-claim-chat/**'
-      - 'app/shareddi/**'
+      - feat/help-center-kmp
+      - feat/puppy-guide-kmp
   workflow_dispatch:
 
 concurrency:

CLAUDE.md

@@ -221,6 +221,43 @@ data-{domain}/
 - Use cases for business logic
 - Room database for local persistence
 
+**Critical architectural rule — never expose GraphQL types in public API:**
+
+GraphQL is an implementation detail of the data layer. Apollo-generated types (anything from the `octopus` package — queries, mutations, fragments, their `.Data` shapes, generated input/enum types, etc.) **must not appear in the signatures of public interfaces, public functions, return types, or public data classes** that other modules consume.
+
+Use cases and repositories should:
+1. Run the GraphQL operation internally (`.query(...)`, `.mutation(...)`, `.safeExecute()`, `.safeFlow()`).
+2. Map the response into a project-owned type (a plain Kotlin `data class`, sealed type, primitive, or `Unit` if only success/failure matters) before returning.
+3. Keep the `octopus.*` import confined to the `internal` impl class only.
+
+This applies even when the GraphQL type happens to be a perfect shape — wrap it. It keeps the rest of the project insulated from schema churn, makes the data source swappable, and prevents GraphQL types from leaking into KMP/iOS-facing APIs where they'd be even more awkward.
+
+Example — wrong:
+```kotlin
+interface SetArticleRatingUseCase {
+  // ❌ exposes Apollo-generated type
+  suspend fun invoke(name: String, rating: Int): Either<ErrorMessage, PuppyGuideEngagementMutation.Data>
+}
+```
+
+Example — right:
+```kotlin
+interface SetArticleRatingUseCase {
+  // ✅ project-owned shape; Unit because callers only care about success/failure
+  suspend fun invoke(name: String, rating: Int): Either<ErrorMessage, Unit>
+}
+
+internal class SetArticleRatingUseCaseImpl(...) : SetArticleRatingUseCase {
+  override suspend fun invoke(...) = either {
+    val data = apolloClient.mutation(PuppyGuideEngagementMutation(...)).safeExecute()
+      .mapLeft { ErrorMessage() }.bind()
+    ensure(data.puppyGuideEngagement.success) { ErrorMessage() }
+  }
+}
+```
+
+When the response carries useful structured data, define a project-owned `data class` next to the use case (or in a shared model file) and map field-by-field in the impl.
+
 ## Technology Stack
 
 ### UI

README.md

@@ -45,4 +45,15 @@ The [android-remove-unused-resources-plugin](https://github.com/irgaly/android-r
 plugin is used to achieve this. This will run on CI using [this task](./.github/workflows/unused-resources.yml), but to run locally one can also just do
 `./gradlew :app:lint -Prur.lint.onlyUnusedResources`
 And then
-`./gradlew :app:removeUnusedResourcesDebug`
+`./gradlew :app:removeUnusedResourcesDebug`
+
+## Sharing code with iOS via HedvigShared
+
+The `:umbrella` module produces the binary the iOS app consumes for shared KMP code — exported module list in `app/umbrella/build.gradle.kts`. Two distribution paths:
+
+- **Production**: `umbrella.yml` runs `:umbrella:assembleHedvigSharedReleaseXCFramework` and publishes the resulting multi-slice XCFramework as a Swift Package (~25 min round-trip).
+- **Local dev**: Ugglan's `scripts/use-local-umbrella.sh` flips its Tuist project so a pre-build phase calls `:umbrella:embedAndSignAppleFrameworkForXcode` from a sibling `android/` checkout on every Xcode build (~5–10s per Kotlin change). See the *Iterating on shared KMP code* section in Ugglan's README.
+
+(`:umbrella:embedAndSignAppleFrameworkForXcode` only works from an Xcode build phase — it reads `CONFIGURATION`, `SDK_NAME`, `ARCHS`, `BUILT_PRODUCTS_DIR` from the env.)
+
+`:umbrella` is `isStatic = true`. Compose Resources you add to shared modules land at `<App>.app/compose-resources/composeResources/...` on iOS via `ugglan/scripts/post-build-action.sh` — that script is the source of truth for the iOS bundle layout.

app/apollo/apollo-octopus-public/src/commonMain/graphql/com/hedvig/android/apollo/octopus/schema.graphqls

@@ -917,13 +917,31 @@ Root type expressing the entire flow for members trying to report a new claim.
 """
 type ClaimIntent {
   id: ID!
+  """
+  The time this was started.
+  """
+  createdAt: DateTime!
+  """
+  All steps that have been taken before the current step. These typically include "current value" data.
+  WARNING: Only query these once when resuming an old intent, as they can be quite expensive to compute.
+  They effectively need to perform all the work of rendering every previous step all at once, which we should
+  generally avoid when going through the flow normally.
+  """
+  previousSteps: [ClaimIntentStep!]!
+  """
+  The current step.
+  """
   currentStep: ClaimIntentStep
   """
   A value between 0.0 and 1.0 that indicates roughly how far along the submission
   flow the user has progressed.
   """
   progress: Float
   """
+  A short summary of the contents of this flow. Null when the flow is completely new (typically pre triage).
+  """
+  displayName: String
+  """
   The created claim of this intent.
   Once this value is returned, the intent is effectively over, and no steps
   can be produced or interacted with.
@@ -964,7 +982,7 @@ type ClaimIntentSourceMessage {
   text: String!
 }
 input ClaimIntentStartInput {
-  developmentFlow: Boolean
+  developmentFlow: Boolean @deprecated(reason: "Unused")
 }
 """
 Represents a single step in the claim submission flow.
@@ -993,6 +1011,14 @@ type ClaimIntentStepContentAudioRecording {
   uploadUri: String!
   freeTextMinLength: Int!
   freeTextMaxLength: Int!
+  """
+  URL of the audio uploaded by the user.
+  """
+  currentAudioUrl: Url
+  """
+  Free text submitted by the user.
+  """
+  currentFreeText: String
   isSkippable: Boolean!
 }
 """
@@ -1038,8 +1064,17 @@ type ClaimIntentStepContentFileUpload {
   The relative URI towards where one should upload the files.
   """
   uploadUri: String!
+  """
+  Current files uploaded by the user.
+  """
+  currentFiles: [ClaimIntentStepContentFileUploadFile!]
   isSkippable: Boolean!
 }
+type ClaimIntentStepContentFileUploadFile {
+  url: Url!
+  contentType: String!
+  fileName: String!
+}
 """
 A form step is one that contains a form in the shape of a list of "fields".
 Submitted using `Mutation.claimIntentSubmitForm`.
@@ -1082,6 +1117,10 @@ type ClaimIntentStepContentFormField {
   """
   defaultValues: [ClaimIntentStepContentFormFieldValue!]!
   """
+  These are the values that the user has submitted for this field.
+  """
+  currentValues: [ClaimIntentStepContentFormFieldValue!]!
+  """
   If type is SEARCH, then this will be present.
   """
   searchData: ClaimIntentStepContentFormFieldSearchData
@@ -1136,8 +1175,21 @@ It can be seen as a special-case form with nicer rendering.
 Submitted using `Mutation.claimIntentSubmitSelect`.
 """
 type ClaimIntentStepContentSelect {
+  """
+  Selectable options.
+  """
   options: [ClaimIntentStepContentSelectOption!]!
+  """
+  Visual style of this selection.
+  """
   style: ClaimIntentStepContentSelectStyle!
+  """
+  Currently selected value by the user.
+  """
+  currentSelectedId: ID
+  """
+  Pre-filled default value.
+  """
   defaultSelectedId: ID
   isSkippable: Boolean!
 }
@@ -2468,6 +2520,11 @@ type Member {
   List of members FAQ
   """
   memberFAQ: MemberFAQ!
+  """
+  Returns the most recent claim intent for this member, that can be "resumed" by querying `ClaimIntent.previousSteps`.
+  Will return `null` if the server considers it too old to be resumed.
+  """
+  resumableClaimIntent: ClaimIntent
   claims: [Claim!]!
   claimsActive: [Claim!]!
   claimsHistory: [Claim!]!
@@ -2531,10 +2588,16 @@ type Member {
   """
   crossSellV2(input: CrossSellInput!): CrossSellV2!
   """
-  Young Pet Guide stories for the member.
-  Returns a list of educational content stories for young pet owners.
+  Shop sessions started by this member that have not yet been signed and are not expired.
+  Ordered by most recent activity first.
+  """
+  ongoingShopSessions: [ShopSession!]!
   """
-  puppyGuideStories: [PuppyGuideStory!]!
+  Young Pet Guide content for the member.
+  Returns the educational content stories plus an indicator of whether the audience
+  is a young dog. Returns null when the member has no active dog contracts.
+  """
+  puppyGuide: PuppyGuide
   """
   Fetch all the active contracts for this member. Active contracts include all insurances that are either
   active today, or to-be-active in the future.
@@ -4388,6 +4451,11 @@ type ProductRecommendation {
   Null when no Insurely data collection is associated with the session.
   """
   externalInsurance: RecommendationExternalInsurance
+  """
+  Best-effort prefill for the product's price calculator, derived from Insurely data, for
+  product-only recommendations where no offer could be generated. Null when no usable prefill exists.
+  """
+  priceIntentData: PricingFormData
 }
 type ProductVariant {
   """
@@ -4460,6 +4528,19 @@ input PuppyEngagementInput {
   read: Boolean
   closed: Boolean
 }
+type PuppyGuide {
+  """
+  Educational content stories for dog owners. The same set is served regardless of dog age.
+  """
+  stories: [PuppyGuideStory!]
+  """
+  True if the member has at least one active dog contract for a dog under 2 years old.
+  Clients should use this to render the content appropriately for the audience —
+  content tailored to puppies will be a better fit when this is true.
+  [null] assumes it's not a young dog, as we do not have this info
+  """
+  forYoungDog: Boolean
+}
 type PuppyGuideStory {
   """
   The unique name/identifier of the story.
@@ -4682,6 +4763,11 @@ type ShopSession {
   """
   cart: Cart!
   """
+  Display-ready summary of this session for surfacing it in member-facing lists
+  (e.g. the Hedvig mobile app's home screen).
+  """
+  display: ShopSessionDisplay!
+  """
   The outcome of a signed shop-session. Requires authentication.
   """
   outcome: ShopSessionOutcome
@@ -4816,6 +4902,49 @@ input ShopSessionCustomerUpdateInput {
   firstName: String
   lastName: String
 }
+type ShopSessionDisplay {
+  """
+  Title summarizing the session's products, e.g. "Car Insurance Full" for a single
+  product or "Home + Accident" when several products are in play. Uses each product's
+  full localized display name (tier-specific where applicable).
+  """
+  title: String!
+  """
+  Optional secondary line with insured-object info, e.g. "Studio apartment, Stockholm".
+  Null when no insured-object data is available.
+  """
+  subtitle: String
+  """
+  Effective monthly price after any campaign/bundle discounts.
+  Null when the session has no priced offers in the cart.
+  """
+  monthlyNet: Money
+  """
+  Original monthly price before any campaign/bundle discounts.
+  Null under the same conditions as `monthlyNet`.
+  """
+  monthlyGross: Money
+  """
+  Most recent activity timestamp on this session.
+  Used for sorting or displaying it relatively (e.g. "2 days ago").
+  """
+  lastActivityAt: DateTime!
+  """
+  Absolute URL to open in a browser to resume this session. Clients open it
+  directly in the device browser, no auth is required.
+  """
+  resumeUrl: String!
+  """
+  Mirrors the underlying session's `validTo`. Clients can use this to hide cards
+  that are expired.
+  """
+  validTo: DateTime!
+  """
+  Pillow image of the primary product in the session, suitable as a card icon.
+  Null when no product is yet associated with the session.
+  """
+  pillowImage: StoryblokImageAsset
+}
 """
 A/B testing experiment configuration for shop sessions.
 Both name and variant should be in SCREAMING_SNAKE_CASE format.

app/app/build.gradle.kts

@@ -194,8 +194,7 @@ dependencies {
   implementation(projects.featureCrossSellSheet)
   implementation(projects.featureDeleteAccount)
   implementation(projects.featureEditCoinsured)
-  implementation(projects.featureFlagsAndroid)
-  implementation(projects.featureFlagsPublic)
+  implementation(projects.featureFlags)
   implementation(projects.featureForever)
   implementation(projects.featureHelpCenter)
   implementation(projects.featureHome)

app/app/src/main/kotlin/com/hedvig/android/app/di/ApplicationModule.kt

@@ -360,7 +360,7 @@ val applicationModule = module {
   )
 }
 
-private class AndroidBuildConfig() : AppBuildConfig {
+private class AndroidBuildConfig : AppBuildConfig {
   override val debug: Boolean = BuildConfig.DEBUG
   override val applicationId: String = BuildConfig.APPLICATION_ID
   override val buildType: String = BuildConfig.BUILD_TYPE

app/app/src/main/kotlin/com/hedvig/android/app/navigation/HedvigNavHost.kt

@@ -348,7 +348,7 @@ internal fun HedvigNavHost(
       hedvigBuildConstants = hedvigBuildConstants,
       openConversation = {
         navigateToNewConversation()
-      }
+      },
     )
     payoutAccountGraph(
       navController = navController,
@@ -456,6 +456,7 @@ internal fun HedvigNavHost(
     helpCenterGraph(
       hedvigDeepLinkContainer = hedvigDeepLinkContainer,
       navController = navController,
+      onNavigateUp = navController::navigateUp,
       onNavigateToQuickLink = onNavigateToQuickLink@{ quickLinkDestination ->
         val destination: Destination = when (quickLinkDestination) {
           QuickLinkChangeAddress -> {

app/app/src/main/kotlin/com/hedvig/android/app/ui/HedvigApp.kt

@@ -39,14 +39,14 @@ import com.hedvig.android.core.demomode.Provider
 import com.hedvig.android.data.paying.member.GetOnlyHasNonPayingContractsUseCase
 import com.hedvig.android.data.settings.datastore.SettingsDataStore
 import com.hedvig.android.feature.cross.sell.sheet.CrossSellSheet
-import com.hedvig.android.notification.badge.data.payment.MissedPaymentNotificationServiceProvider
 import com.hedvig.android.feature.login.navigation.LoginDestination
 import com.hedvig.android.featureflags.FeatureManager
 import com.hedvig.android.language.LanguageService
 import com.hedvig.android.logger.logcat
 import com.hedvig.android.navigation.activity.ExternalNavigator
 import com.hedvig.android.navigation.compose.typedHasRoute
 import com.hedvig.android.navigation.core.HedvigDeepLinkContainer
+import com.hedvig.android.notification.badge.data.payment.MissedPaymentNotificationServiceProvider
 import com.hedvig.android.ui.force.upgrade.ForceUpgradeBlockingScreen
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.channels.Channel

app/app/src/main/kotlin/com/hedvig/android/app/ui/HedvigAppState.kt

@@ -178,7 +178,6 @@ internal class HedvigAppState(
     false,
   )
 
-
   /**
    * UI logic for navigating to a top level destination in the app. Top level destinations have
    * only one copy of the destination of the back stack, and save and restore state whenever you
@@ -222,7 +221,6 @@ internal class HedvigAppState(
   }
 
   fun navigateToLoggedOut() {
-
     val isLoggingOutFromProfile = navController.currentDestination
       ?.typedHasRoute(destinationToExcludeFromSavingState) ?: false