Open
Conversation
HendrikVE
requested changes
Aug 9, 2021
Owner
HendrikVE
left a comment
HendrikVE
left a comment
There was a problem hiding this comment.
After you fixed the name issue please do a proper rebase and squash, there are unrelated changes in the commit history (like changing readReg to public instead of private).
| writeReg(REG_MODE2, newReg); | ||
| } | ||
|
|
||
| void PCA9633::setInvertState(uint8_t invert) { |
Owner
There was a problem hiding this comment.
Code does not compile because invert needs to be renamed to state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds control of the global output invert bit in MODE2 register. Useful when using the PCA9633 with external drivers.