fix MediaFileResponse #1
Open
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request fixes the structure of two MediaFileResponse references in the OpenAPI specification to comply with proper OpenAPI 3.x standards. Previously, the responses incorrectly used direct $ref to schemas instead of wrapping them in proper response objects with descriptions and content specifications.
Changes:
- Converted POST
/api/index.php/v1/media/files200 response to proper OpenAPI response structure - Converted PATCH
/api/index.php/v1/media/files/{path}200 response to proper OpenAPI response structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
Thank you for your PR and sorry for my late reply. I had already changed the things you did in the PR, just hadn't pushed it yet at the time you created the PR. Will have a good look if I really got this PR covered, and then close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the MCP sprint, I attempted to work with the json file. In doing so, these two response details were criticised. This PR standardises the return.