Skip to content

Fix unsafe error handling and cache state logic bugs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HiGarfield merged 4 commits into from
Apr 6, 2026
Merged

Fix unsafe error handling and cache state logic bugs #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1ab05b
fix(fetch): only skip save on exact cache key match, not restore-key …
Copilot Apr 6, 2026
8f17777
fix(save): check cacheId !== -1 instead of truthy to detect save success
Copilot Apr 6, 2026
9def666
fix(save): use cacheId > -1 for more defensive success check
Copilot Apr 6, 2026
2c46248
fix: safely handle non-Error thrown values in catch blocks
Copilot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ try {
if (cacheFetchingResult) {
core.info(`${cacheFetchingResult} cache fetched!`);
core.setOutput("hit", "1");
core.saveState("CACHE_STATE", "hit");
if (cacheFetchingResult === keyString) {
core.saveState("CACHE_STATE", "hit");
}

if (cacheToolchain && skipBuildingToolchain) {
execSync("sed -i 's/ $(tool.*\\/stamp-compile)//;' Makefile");
Expand All @@ -42,5 +44,5 @@ try {
}
}
} catch (error) {
core.setFailed(error.message);
core.setFailed(error instanceof Error ? error.message : String(error));
}
4 changes: 2 additions & 2 deletions save.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ try {
core.debug(`Cache paths: ${paths.join(", ")}`);

const cacheId = await cache.saveCache(paths, keyString);
if (cacheId) {
if (cacheId > -1) {
core.info(`Cache saved with key: ${keyString} (id: ${cacheId})`);
}
} else {
core.debug("No paths configured for caching, skipping");
}
}
} catch (error) {
core.warning(error.message);
core.warning(error instanceof Error ? error.message : String(error));
}