Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…date - Add `N::Integer` annotation to `cachedinterpolators` for an immediate, clear MethodError on non-integer input - Make `Interpolations.gradient` self-contained: inlines the cache-update block from the functor so callers no longer need a prior `itp(ys...)` call; adds a docstring and removes the FIXME comment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
===========================================
- Coverage 100.00% 91.07% -8.93%
===========================================
Files 1 1
Lines 47 56 +9
===========================================
+ Hits 47 51 +4
- Misses 0 5 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
N::Integerannotation incachedinterpolators: passing a non-integerNnow raises a clearMethodErrorimmediately instead of a confusing downstream failure.gradientcache fix:Interpolations.gradientnow updates the cache itself (same branch as the functor), so it is safe to call without a precedingitp(ys...). The FIXME comment is replaced by a docstring.gradient!is fixed transitively.0.14to0.15; TagBot workflow comment cleaned up.1.0.0→1.0.1Test plan
Test.detect_ambiguities(CachedInterpolations)returns 0 (unchanged)gradientreturns correct results without a prior functor call🤖 Generated with Claude Code