Conversation
…tMatrix Allows callers to pass SVector/SMatrix results from mms2fit! directly into qbuild without an intermediate copy or conversion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… uclamp! Surfaces misuse (e.g. scalar maxshift) as a MethodError at the call site rather than a confusing indexing error inside the function body. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
uclamp(u, maxshift) copies u and delegates to uclamp!, following the sort/sort! convention. Exported and documented with a cross-reference to uclamp!. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Uses deepcopy rather than copy because interpolate_mm! writes B-spline coefficients into each MismatchArray's .data in-place (InPlace BSpline), so a shallow copy would alias the original's storage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a solver_kwargs = (;) keyword to qfit that is splatted into the NLsolve.nlsolve call, letting callers tune ftol, xtol, iterations, etc. without the package having to enumerate nlsolve's full option set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The internal qfit(mm, thresh, maxsep, opt::Bool) form, which leaked an implementation detail into the public API, is renamed to _qfit. The sole public interface is now qfit(mm, thresh; maxsep, opt, solver_kwargs). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The abbreviation "pat" (principal axes transform) is opaque and inconsistent with the companion function principalaxes. The new name makes the pipeline principalaxes → principalaxes_rotation self-evident. No deprecation shim per stated values. Docs and README updated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 75.46% 75.60% +0.14%
==========================================
Files 1 1
Lines 326 328 +2
==========================================
+ Hits 246 248 +2
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pat_rotationrenamed toprincipalaxes_rotation— aligns naming with the companionprincipalaxesfunctionqfit4-argument positional form removed; keyword-only form is now the sole public interfaceuclampandmms2fitnon-mutating counterpartsqfitacceptssolver_kwargsforwarded tonlsolveqbuildtype annotations widened (Vector/Matrix→AbstractVector/AbstractMatrix);maxshiftannotated asUnion{AbstractVector,Tuple}acrossqbuild,uisvalid,uclamp!Test plan
Pkg.test())Test.detect_ambiguities(RegisterFit)= 0 (baseline was 0)@test_throws MethodErrorguards on both breaking removals🤖 Generated with Claude Code