Conversation
- Add Aqua as test dependency with all checks passing - Remove piracy: sdims/coords_spatial on CuArray (AbstractArray fallbacks suffice) - Add missing compat bounds for SharedArrays, Test, CenterIndexedArrays, ImageFiltering - Upgrade CUDA 5.6.1 → 5.11.2 (5.6.x incompatible with Julia 1.12) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
No fields were ever reassigned after construction — all mutations operated on array contents via copyto!, fill!, and GPU kernels. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Three bugs in src/ and three in test/ were found while adding coverage: - CuRCpair(A::Array): wrong constructor call and copyto! used linear indexing across mismatched shapes, corrupting data beyond the first column - mismatch!: error message referenced undefined variable `normalizeby` - runtests.jl: separate/truncatenoise!/indmin_mismatch called via wrong module New testsets cover CuRCpair(::Array), CMStorage eltype/ndims accessors, and the invalid-normalization error path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add docstrings for CuRCpair and fillfixed! (previously undocumented) - Remove stale gridsize call form and flags=FFTW.MEASURE from mismatch_apertures (copy-paste artifacts from CPU package) - Convert all inline-signature style to standard 4-space-indented blocks - Switch present-tense verbs to imperative mood throughout - Add return type annotations to all function docstrings - Document m_offset keyword on mismatch! - Add workflow description and examples to CMStorage and mismatch_apertures! - Fix module docstring to list only symbols in this package Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
=========================================
+ Coverage 0.50% 0.52% +0.01%
=========================================
Files 2 2
Lines 198 192 -6
=========================================
Hits 1 1
+ Misses 197 191 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AtomixCUDAExt (transitive CUDA.jl dep) declares __precompile__(false), which crashes Aqua's precompilation subprocess. Mark broken until fixed upstream. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The precompilation subprocess crash is a Julia 1.10-era issue; the check passes cleanly on 1.11+. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CuRCpairandCMStorageconstructorsmutable structs to plain structs (no fields mutated in place)Test plan
minand1Julia versions🤖 Generated with Claude Code