Enable formula path helper cop#22845
Merged
Merged
Conversation
MikeMcQuaid
force-pushed
the
formula-path-methods-cop
branch
from
0f390f3 to
47616ea
Compare
MikeMcQuaid
force-pushed
the
formula-path-methods-enable-formulae
branch
from
c4793ce to
7d161de
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the Homebrew/FormulaPathMethods RuboCop cop by removing its temporary exclusion for Formula/**/*.rb, now that Homebrew/core has been updated to accommodate the autocorrections.
Changes:
- Removes the
Homebrew/FormulaPathMethodsconfiguration block that excluded formula files from this cop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Re-enable formula autocorrection after Core has been updated. - Include service blocks so formula helpers work in service DSLs.
MikeMcQuaid
force-pushed
the
formula-path-methods-enable-formulae
branch
from
7d161de to
c0ea3ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable formula autocorrection after homebrew/core has been updated.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review.