Simple Fixes and Documentation#4
Open
PyroFlareX wants to merge 5 commits into
Open
Conversation
Author
|
Fixed bad commenting |
ghost
reviewed
Aug 2, 2018
| : fonts ("fonts", "ttf") | ||
| , textures ("txrs", "png") | ||
| , soundBuffers ("sfx", "ogg") | ||
| //, soundBuffers ("sfx", "ogg") Commented because of a linux error on SFML 2.5.0 |
There was a problem hiding this comment.
No errors for me on Fedora 28 Linux. Are you sure?
ghost
reviewed
Aug 2, 2018
| ResourceManager<sf::Font> fonts; | ||
| ResourceManager<sf::Texture> textures; | ||
| ResourceManager<sf::SoundBuffer> soundBuffers; | ||
| //ResourceManager<sf::SoundBuffer> soundBuffers; //Commented out because of Linux(possibly) error in sfml 2.5.0 with a std::pair error |
There was a problem hiding this comment.
Again no errors for me on Fedora 28 Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really documentation, but some comments explaining why things are done. Some suggestions for an actual project are in. The SFML audio related stuff is commented out as a fix to an error I had. No changes to the code other than the comments. First PR!