Do not include non_persistent buffer in state_dict#1826
Merged
emailweixu merged 1 commit intopytorchfrom Jan 23, 2026
Merged
Conversation
le-horizon
approved these changes
Jan 22, 2026
Contributor
le-horizon
left a comment
le-horizon
left a comment
There was a problem hiding this comment.
LG.
Could you add a bit more explanation in the PR desc, which case this fix is for? E.g. two modules sharing parameter? or the other case?
Thanks,
Le
Contributor
Author
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the original implementation of state_dict for pytorch Module, non persistent buffers are not included in state_dict.
Background: state_dict usually include both parameters and buffers. However, if a buffer is registered with persistent=False, it will not be included in state_dict (the default value for persistent is True).