feat(installer): skip embedding-model step on graph-only installs#385
Merged
Conversation
…-MI5) The install wizard's Stage 2 (embedding-model selection) is inert on a graph-only install (macOS Intel): there is no vector index to embed into, so asking for a model path the user cannot use is noise. Gate it on a new pipeline.vector_stack_installed() probe (find_spec on cocoindex/lancedb/ sentence-transformers) and print a clear skip message instead. The graph still builds via the PR-MI3 skip-on-blocker path in init. Full-mode behavior is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #382 (macOS Intel graph-only support).
The
installwizard's Stage 2 (embedding-model selection) is inert on a graph-only install (macOS Intel): there's no vector index to embed into, so prompting for a model path the user can't use is noise. This gates that step on a newpipeline.vector_stack_installed()probe and prints a clear skip message instead. The graph still builds via the skip-on-blocker path landed in #382.Changes
java_codebase_rag/pipeline.py: addvector_stack_installed()—find_specprobe overcocoindex/lancedb/sentence_transformers(gated together by the PEP 508 markers from feat(platform): macOS Intel support via graph-only mode (PR-MI1..MI4) #382).java_codebase_rag/installer.py: Stage 2 skipsresolve_model()and setsresolved_model = "auto"when the vector stack is absent, with an explanatory message.tests/test_graph_only_boot.py: deterministic subprocess test that the probe reportsFalsewhen the stack is blocked (runs on any platform).Verification
vector_stack_installed():Truein full mode,Falseunder graph-only simulation.tests/test_installer.py+tests/test_graph_only_boot.py: 88 passed; ruff clean.True, soresolve_modelruns as before).🤖 Generated with Claude Code