feat: allow for line return tsid parsing#230
Open
msweier wants to merge 1 commit into
Open
Conversation
krowvin
approved these changes
Jul 6, 2026
krowvin
reviewed
Jul 6, 2026
| ts_ids = None | ||
| if ts_id: | ||
| ts_ids = [item.strip() for item in ts_id.split(",") if item.strip()] | ||
| ts_ids = [item.strip() for item in re.split(r"[,\r\n]+", ts_id) if item.strip()] |
Collaborator
There was a problem hiding this comment.
Just making a one-off comment here that carriage return is typically windows. But I suspect these would always be pasted from windows?
And noting it would probably be this logic?
, or \r or \n
Collaborator
Author
There was a problem hiding this comment.
Yes, but just trying to cover the bases. And yes that is the correct logic. It will split any combination of commas, /r, or /n. The + will treat any consecutive delimiters (like \r\n) as one.
Tested , and /r locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for
load timeseries datato use a line return as tsid parsing so you can cut and paste tsids from cwms-vue