-
Notifications
You must be signed in to change notification settings - Fork 2
feat(flashing-view): add standalone flashing view #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
l-castel
wants to merge
14
commits into
develop
Choose a base branch
from
features/flashing-view
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6cc8eeb
feat*: flashing view integrated onto main app. changed electron confi…
l-castel bd050c0
fix(workspace): fixed pnpm workspace to integrate the flashing-view r…
l-castel 7b5664b
fix(workspace): added python package and logger to .gitignore
l-castel 55e024c
fix(electron): fixed gitignores.
l-castel 43d26c4
chore(electron-app): stop tracking python and logger folders
l-castel ef462b6
chore(testing-view): remove embedded flash-station feature
l-castel 537c0f7
chore(electron-app): revert to develop baseline
l-castel 73349a6
chore(flashing-view): move app into frontend/ alongside other views
l-castel 4459172
feat(ui-kit): add Table component and missing icons; update flashing-…
l-castel 7dc018d
chore(old flashing-view): deleted old flashing-view implementation
l-castel 28f3e4e
fix(GITIGNORE): updated gitignore
l-castel 1083e5e
fix(build): fixed build errors
l-castel bc88c9b
fix(ci): install flashing-view + competition-view deps in frontend-te…
l-castel 4cdd818
fix(electron): typo on electron config
l-castel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,8 @@ node_modules/ | |
| .env | ||
|
|
||
| # Global binaries | ||
| *.exe | ||
| *.exe | ||
|
|
||
| # electron modules | ||
| electron-app/python | ||
| electron-app/logger | ||
|
l-castel marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { useEffect } from 'react'; | ||
|
|
||
| export const FlashPage = () => { | ||
| useEffect(() => { | ||
| if ((window as any).electronAPI?.switchView) { | ||
| (window as any).electronAPI.switchView('flashing-view'); | ||
| } | ||
| }, []); | ||
|
|
||
| return ( | ||
| <div style={{ | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| height: '100vh', | ||
| width: '100%', | ||
| color: 'var(--text-color)' | ||
| }}> | ||
| <p>Opening flashing view...</p> | ||
| </div> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { FlashPage } from "./FlashPage"; | ||
|
|
||
| export const flashRoute = { | ||
| path: "/flash", | ||
| element: <FlashPage/> | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.