fix(eval): block self-judging rows for llm_judge#344
Open
ulises-jeremias wants to merge 2 commits into
Open
Conversation
Signed-off-by: ulises-jeremias <ulisescf.24@gmail.com>
Signed-off-by: ulises-jeremias <ulisescf.24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent self-judging in offline evaluation when
llm_judgeis active.This change adds a guard that rejects any evaluated row where the trajectory
modelmatches--judge-model(withlitellm_proxy/prefix normalization). This avoids candidate=self-judge comparisons in the default evaluation path.Type of Change
Impact on Benchmarking
Related Issues
Verification Steps
uvx ruff check src/evaluation/evaluator.py src/evaluation/runner.py src/evaluation/cli.py src/evaluation/tests/test_evaluator.pyuv run pytest src/evaluation/testsChecklist
Notes
judge_modelintoEvaluatorandevaluation.runner.evaluate(...)so the same guard applies to CLI and programmatic evaluation.claude-agentcandidate runs are no longer paired with the same judge model in docs.Additional Quick Notes
llm_judgeand ajudge_modelis provided.litellm_proxy/to avoid false negatives with equivalent model IDs.