Conversation
konyvmoly
approved these changes
Feb 24, 2026
mojito317
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
A couple of fixes related to the eslint 9 changes in #2015 and recent dependabot update behaviour.
Fixes: part of i532
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
#2015 included
eslint-config-prettierin thepackage-lock.jsonbut not thepackage.json(this was my error as I tried to cleanup the imports to just what we needed). It worked becausenpm cikept the module around, but now dependabot is trying to clean it up as part of other updates e.g. #2019 and that causes failure.Also there has been some drift on the eslint related dependabot groups due to changes and moves. This means we are missing some eslint related imports from the group and eslint plugins should be updated independently of eslint. The major version update is stopping plugins receiving updates in the group (we can manually ignore the major to split the group, but in general it seems better to have 2 groups). The patch level ignore is also going to delay a (harmless from this perspective) redos CVE resolution in the depoendency chain.
What is the new behavior?
eslint-config-prettiertopackage.jsonand associatedpackage-lock.jsoncleanup.eslintandeslint-pluginseslint*and@typescript-eslint/*(they run only weekly anyway)Does this PR introduce a breaking change?
Other information