Skip to content

Follow up fixes for eslint 9 changes#2021

Merged
ricellis merged 2 commits intomainfrom
i532-plugin-fix
Feb 24, 2026
Merged

Follow up fixes for eslint 9 changes#2021
ricellis merged 2 commits intomainfrom
i532-plugin-fix

Conversation

@ricellis
Copy link
Member

PR summary

A couple of fixes related to the eslint 9 changes in #2015 and recent dependabot update behaviour.

Fixes: part of i532

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

#2015 included eslint-config-prettier in the package-lock.json but not the package.json (this was my error as I tried to cleanup the imports to just what we needed). It worked because npm ci kept the module around, but now dependabot is trying to clean it up as part of other updates e.g. #2019 and that causes failure.

Also there has been some drift on the eslint related dependabot groups due to changes and moves. This means we are missing some eslint related imports from the group and eslint plugins should be updated independently of eslint. The major version update is stopping plugins receiving updates in the group (we can manually ignore the major to split the group, but in general it seems better to have 2 groups). The patch level ignore is also going to delay a (harmless from this perspective) redos CVE resolution in the depoendency chain.

What is the new behavior?

  • Add eslint-config-prettier to package.json and associated package-lock.json cleanup.
  • Two dependabot groups eslint and eslint-plugins
  • Remove patch level ignores for eslint* and @typescript-eslint/* (they run only weekly anyway)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis self-assigned this Feb 24, 2026
@ricellis ricellis requested a review from a team as a code owner February 24, 2026 09:44
@ricellis ricellis merged commit cc1ce7d into main Feb 24, 2026
9 checks passed
@ricellis ricellis deleted the i532-plugin-fix branch February 24, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants