Skip to content

devops: switch to @tony.ganchev/eslint-plugin-header#2031

Closed
tonyganchev wants to merge 1 commit intoIBM:mainfrom
tonyganchev:main
Closed

devops: switch to @tony.ganchev/eslint-plugin-header#2031
tonyganchev wants to merge 1 commit intoIBM:mainfrom
tonyganchev:main

Conversation

@tonyganchev
Copy link

PR summary

Reasons:

  • The fork is supported and updated.
  • ESLint 9-native with full schema support and needing no hacks.
  • Windows support
  • Multiple other bugfixes.
  • UX improvements - better error messages and more autofix capabilities.
  • Extensive documentation.
  • Better configuration format (although the old one is still supported).

Fixes: (not sure if non-maintainers should spam with devops issues).

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • [v] The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • [v] Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

N/A

What is the new behavior?

N/A

Does this PR introduce a breaking change?

  • Yes
  • [v] No

Other information

@tonyganchev tonyganchev requested a review from a team as a code owner March 6, 2026 21:27
Reasons:
- The fork is supported and updated.
- ESLint 9-native with full schema support and needing no hacks.
- Windows support
- Multiple other bugfixes.
- UX improvements - better error messages and more autofix capabilities.
- Extensive documentation.
- Better configuration format (although the old one is still supported).

Signed-off-by: Tony Ganchev <tony.ganchev@gmail.com>
@ricellis
Copy link
Member

Thank you for proposing this change.
At the moment the existing eslint-plugin-header is working for our case so we are not inclined to make an unnecessary change at this time.
However, we will definitely keep your plugin in mind if we need to change in the future though - thanks!

@ricellis ricellis closed this Mar 11, 2026
import customTsRules from './.eslint-rules-ts.mjs';

// Disable schema checking for eslint-plugin-header
header.rules.header.meta.schema = false;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricellis I just realized I did not clear out this hack from the PR. This is the immediate benefit of not using the original project.

@tonyganchev
Copy link
Author

Thank you for proposing this change. At the moment the existing eslint-plugin-header is working for our case so we are not inclined to make an unnecessary change at this time. However, we will definitely keep your plugin in mind if we need to change in the future though - thanks!

Thanks, makes sense. Please take a look at the comment above - the ugly hack that was needed so that eslint-plugin-header is no longer needed but I forgot to remove it in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants