Merged
Conversation
157a227 to
3f5e1f9
Compare
mojito317
reviewed
Jul 17, 2025
mojito317
approved these changes
Jul 17, 2025
4e60e06 to
1edd9d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Various fixes for pagination
Fixes: s1189
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
The new pagination feature code (unreleased) from #819 had a few bugs.
keyoption was allowed for view-like pagersskipoption set by user was not removed from subsequent pagesWhat is the new behavior?
Pagerstate error message stringskeyas an option for paginationskipoption from subsequent pagesPagerstate tests to ensure the correct messagekeyoption validationskipoption changesDoes this PR introduce a breaking change?
Other information