Sample data fix#5
Open
Ellmen wants to merge 3 commits into
Open
Conversation
|
Hi, author! Your project is pretty charming! But I also have a question about the sample_pipeline.py and the static_eval.py. When I ran the sample_pipeline.py. It showed me the "AssertionError: need dumped states, run static_eval first". But after I ran the static_eval.py, it still doesn't work. I guess maybe there are some mistakes in the static_eval. Can you help me to address that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the very interesting code.
As discussed in #1, the
create_datasets.pyandcfg.pydon't work with the data provided. In particular, there is no solubility data, the data labels are mismatched, and the truncated datasets are missing values which cause issues when filtering datasets. This minimally updates those files to be able to run the sample code with:I also added Mac support on my fork if that would be of interest.