Skip to content

[UI] Vite Migration #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayuka-c wants to merge 2 commits into
base: main
Choose a base branch
from
+1,795 −10,017
Open

[UI] Vite Migration #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aad9d4
Vite Migration
mayuka-c Feb 18, 2026
219548e
Vite dev dependency
mayuka-c Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions web/public/index.html → web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta
name="description"
content="A self-service portal for accessing Power Hardware resources, enabling seamless development, testing, and optimization on Power Architecture."
/>
<script src="%PUBLIC_URL%/env-config.js"></script>
<script src="/env-config.js"></script>
<script
src="https://cdn.jsdelivr.net/npm/react/umd/react.production.min.js"
Copy link
Contributor

@Niharika0306 Niharika0306 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do these external scripts do?

Copy link
Member Author

@mayuka-c mayuka-c Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good question. We need only env-config.js for loading the env's
Rest seems like it already existed, so I have kept it.

Maybe we can do the cleanup seperately.

Copy link
Contributor

@Niharika0306 Niharika0306 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can do that.

crossorigin
Expand All @@ -28,25 +28,16 @@
<script>
var Alert = ReactBootstrap.Alert;
</script>
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
<link rel="apple-touch-icon" href="/logo192.png" />
<!--
manifest.json provides metadata used when your web app is installed on a
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
-->
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<!--
Notice the use of %PUBLIC_URL% in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.

Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<link rel="manifest" href="/manifest.json" />
<title>IBM&reg; Power&reg; Access Cloud</title>
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<script type="module" src="/src/index.jsx"></script>
<div id="root"></div>
Copy link
Contributor

@Niharika0306 Niharika0306 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the script tag be moved after the root div , for better loading.

Suggested change
<div id="root"></div>
<div id="root"></div>
<script type="module" src="/src/index.jsx"></script>

Copy link
Member Author

@mayuka-c mayuka-c Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will be doing it. Thanks

<!--
This HTML file is a template.
Expand Down
25 changes: 6 additions & 19 deletions web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"axios": "^1.13.5",
"bootstrap": "^5.3.0",
"env-cmd": "^10.1.0",
"http-proxy-middleware": "^2.0.9",
"keycloak-js": "^26.2.0",
"marked": "^9.1.0",
"react": "^18.2.0",
Expand All @@ -23,18 +22,16 @@
"redux-logger": "^3.0.6",
"redux-persist": "^6.0.0",
"redux-thunk": "^2.4.2",
"sass": "^1.63.4",
"web-vitals": "^2.1.4"
"sass": "^1.63.4"
},
"devDependencies": {
"react-scripts": "5.0.1"
"@vitejs/plugin-react": "^5.1.4",
"vite": "^7.3.1"
},
"scripts": {
"dev": "chmod +x ./env.sh && ./env.sh && cp env-config.js ./public/ && react-scripts start",
"start": "env-cmd react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
"dev": "chmod +x ./env.sh && ./env.sh && cp env-config.js ./public/ && vite",
"start": "env-cmd vite",
"build": "vite build"
},
"eslintConfig": {
"extends": [
Expand All @@ -53,15 +50,5 @@
"last 1 firefox version",
"last 1 safari version"
]
},
"resolutions": {
"nth-check": "^2.0.1",
"rollup": "^2.79.2",
"ws": "^7.5.10",
"path-to-regexp": "^0.1.12",
"body-parser": "^1.20.3",
"braces": "^3.0.3",
"postcss": "^8.4.31",
"form-data": "^3.0.4"
}
}
6 changes: 0 additions & 6 deletions web/src/index.js → web/src/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import ReactDOM from "react-dom/client";
import {BrowserRouter} from "react-router-dom"
import "./index.scss";
import App from "./components/App";
import reportWebVitals from "./reportWebVitals";
import UserService from "./services/UserService";
import { Provider } from "react-redux";
import { store } from "./store/store";
Expand All @@ -30,8 +29,3 @@ const handleInitError = (error) => {
};

UserService.initKeycloak(renderApp, handleInitError);

// If you want to start measuring performance in your app, pass a function
// to log results (for example: reportWebVitals(console.log))
// or send to an analytics endpoint. Learn more: https://bit.ly/CRA-vitals
reportWebVitals();
13 changes: 0 additions & 13 deletions web/src/reportWebVitals.js
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions web/src/setupProxy.js
View file
Open in desktop

This file was deleted.

19 changes: 19 additions & 0 deletions web/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";

export default defineConfig({
plugins: [react()],
build: {
outDir: "build",
},
server: {
port: 3000,
proxy: {
"/pac-go-server": {
target: "http://localhost:8000",
Copy link
Contributor

@Niharika0306 Niharika0306 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we are hardcoding the target to localhost:8000, but I believe we were also using a env variable (REACT_APP_PAC_GO_SERVER_TARGET ) earlier in setupProxy.js to point to a dev server.
Can you address this changes?

Copy link
Member Author

@mayuka-c mayuka-c Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that. I will be creating a Vite env variable as we require it only for dev and add it here.

changeOrigin: true,
rewrite: (path) => path.replace(/^\/pac-go-server/, '/api/v1'),
}
},
},
});
Loading
Loading