Open
Conversation
- added german prompts and german flow yaml - added 2 more parsing blocks to the last llm block - fixed a bug in the chunking process - fixed the jsonl-> csv conversion script - added the newly created golden dataset Signed-off-by: Manali Latkar <manali.latkar@ibm.com>
Member
dharaneeshvrd
left a comment
dharaneeshvrd
left a comment
There was a problem hiding this comment.
except the minor comment, I am not able to provide any other comment
@iv1111 please review the german prompt and the golden dataset generated.
| answer = item.get('answer', [{}]) | ||
| if not type(answer) is list or len(answer) == 0: | ||
| answer = [{}] | ||
| answer = item.get('answer', '') |
Member
There was a problem hiding this comment.
this will never return you None
Suggested change
| answer = item.get('answer', '') | |
| answer = item.get('answer') |
this will
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.