Conversation
…p.css - Regenerate 31 ui/* components from shadcn-svelte nova style - Import tw-animate-css + shadcn-svelte/tailwind.css; drop hand-maintained duplicates (data-* variants, no-scrollbar, accordion keyframes) - Re-add badge success variant; bump @lucide/svelte to ^1.21
Replace manual mr-*/ml-*/h-4 w-4/size={n} icon spacing inside Button and
DropdownMenu.Item with data-icon="inline-start"|"inline-end" per nova style.
Leaves standalone/decorative icons unchanged.
Migrate all ui/* components to the nova registry style, adopt the data-icon convention, reconcile app.css (tw-animate-css + shadcn-svelte/tailwind.css), and bump @lucide/svelte to ^1.21.
There was a problem hiding this comment.
Pull request overview
This PR broadly migrates the frontend to the current shadcn-svelte registry style (new component implementations + data-icon convention), updates several route/component layouts accordingly, and adds backend support to persist scenario executor identity + partial assertion progress mid-run (so the UI can show live details while a run is still running).
Changes:
- Regenerate/adjust many
ui/*components (plus new primitives likeTextarea,InputGroup,Popoverpieces,Pagination) and migrate consumers to the newdata-icon="inline-start|inline-end"icon-spacing convention. - Add mid-run scenario persistence: runner emits identity/assertion callbacks; web layer writes partial updates into
scenario_results; fakes/tests updated. - Add/extend OpenSpec documentation for the frontend design system, live scenario detail, and assessment retention/connectors parity.
Reviewed changes
Copilot reviewed 197 out of 210 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| web/frontend/src/routes/scenarios/+page.svelte | Migrates button icon usage to data-icon convention. |
| web/frontend/src/routes/scenarios/[id]/edit/+page.svelte | Refactors prop passing to shorthand {initialX} syntax. |
| web/frontend/src/routes/scenarios/[id]/+page.svelte | Migrates action button icons to data-icon; minor markup formatting tweaks. |
| web/frontend/src/routes/packs/+page.svelte | Minor formatting change for search icon markup. |
| web/frontend/src/routes/+layout.svelte | Removes manual icon sizing/margins in dropdown menu item. |
| web/frontend/src/lib/utils/format.ts | Adds formatRelativeTime() utility. |
| web/frontend/src/lib/stores/scenario-tracker.svelte.ts | Carries partial result for running/pending entries for richer live UI. |
| web/frontend/src/lib/components/ui/tooltip/tooltip.svelte | Adds generics typing for bits-ui tooltip root props. |
| web/frontend/src/lib/components/ui/tooltip/tooltip-trigger.svelte | Adds generics typing for bits-ui tooltip trigger props. |
| web/frontend/src/lib/components/ui/tooltip/tooltip-provider.svelte | Adds delayDuration prop passthrough (default 0). |
| web/frontend/src/lib/components/ui/tooltip/tooltip-content.svelte | Updates tooltip styling/classes for new registry style. |
| web/frontend/src/lib/components/ui/toggle/toggle.svelte | Updates toggle variants (styling + sizing + icon padding rules). |
| web/frontend/src/lib/components/ui/toggle-group/toggle-group.svelte | Adds orientation support; updates context + styling. |
| web/frontend/src/lib/components/ui/toggle-group/toggle-group-item.svelte | Updates item styling to match new toggle-group conventions. |
| web/frontend/src/lib/components/ui/textarea/textarea.svelte | New textarea primitive component. |
| web/frontend/src/lib/components/ui/textarea/index.ts | Exports Textarea (Root alias). |
| web/frontend/src/lib/components/ui/tabs/tabs.svelte | Updates tabs root layout classes for orientation variants. |
| web/frontend/src/lib/components/ui/tabs/tabs-trigger.svelte | Updates trigger styling for new tabs list variants/orientation. |
| web/frontend/src/lib/components/ui/tabs/tabs-list.svelte | Introduces variant API + tabsListVariants via tailwind-variants. |
| web/frontend/src/lib/components/ui/tabs/tabs-content.svelte | Adds default text-sm styling to tab content. |
| web/frontend/src/lib/components/ui/tabs/index.ts | Exports tabs list variants + variant type. |
| web/frontend/src/lib/components/ui/table/table-row.svelte | Simplifies hover styling for table rows. |
| web/frontend/src/lib/components/ui/table/table-head.svelte | Updates table head alignment + padding utilities. |
| web/frontend/src/lib/components/ui/table/table-cell.svelte | Simplifies class composition and padding utilities. |
| web/frontend/src/lib/components/ui/switch/switch.svelte | Adds size prop + updates switch styling and thumb rules. |
| web/frontend/src/lib/components/ui/sonner/sonner.svelte | Normalizes import quoting/style. |
| web/frontend/src/lib/components/ui/sonner/index.ts | Normalizes import quoting/style. |
| web/frontend/src/lib/components/ui/skeleton/skeleton.svelte | Updates skeleton styling token from accent to muted. |
| web/frontend/src/lib/components/ui/sidebar/sidebar.svelte | Mobile sheet sidebar: binds ref, merges className, tweaks widths/rings. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-trigger.svelte | Binds ref; updates button size variant + class naming. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-separator.svelte | Adds horizontal margin and auto width. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-rail.svelte | Attribute normalization + class tweaks for rail positioning. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-menu.svelte | Adjusts spacing/gap conventions. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-menu-sub.svelte | Refactors submenu layout + class ordering. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-menu-sub-button.svelte | Updates submenu button classes to new data-* conventions. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-menu-skeleton.svelte | Class reordering / minor layout adjustments. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-menu-button.svelte | Updates base variant classes + data-* conventions. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-menu-badge.svelte | Updates badge positioning utilities and data-* conventions. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-menu-action.svelte | Updates action positioning, data-* conventions, and hover behavior. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-inset.svelte | Updates inset layout utilities (logical → physical left). |
| web/frontend/src/lib/components/ui/sidebar/sidebar-header.svelte | Class reordering / spacing tweaks. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-group.svelte | Class reordering / spacing tweaks. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-group-label.svelte | Updates label styling + collapsed behavior classes. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-group-content.svelte | Class reordering / minor layout tweaks. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-group-action.svelte | Updates action positioning + hit target behavior. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-footer.svelte | Class reordering / spacing tweaks. |
| web/frontend/src/lib/components/ui/sidebar/sidebar-content.svelte | Adds no-scrollbar and removes gap. |
| web/frontend/src/lib/components/ui/sidebar/constants.ts | Renames sidebar cookie name constant. |
| web/frontend/src/lib/components/ui/sheet/sheet-title.svelte | Updates title typography. |
| web/frontend/src/lib/components/ui/sheet/sheet-overlay.svelte | Updates overlay styling (blur + opacity) and removes animations. |
| web/frontend/src/lib/components/ui/sheet/sheet-header.svelte | Adjusts spacing/gap conventions. |
| web/frontend/src/lib/components/ui/sheet/sheet-footer.svelte | Adjusts spacing/gap conventions. |
| web/frontend/src/lib/components/ui/sheet/sheet-content.svelte | Refactors side typing + styling; adds optional close button via Button. |
| web/frontend/src/lib/components/ui/separator/separator.svelte | Adjusts vertical separator sizing rules. |
| web/frontend/src/lib/components/ui/select/select-trigger.svelte | Updates trigger styling + chevron icon styling. |
| web/frontend/src/lib/components/ui/select/select-separator.svelte | Class reordering only. |
| web/frontend/src/lib/components/ui/select/select-scroll-up-button.svelte | Updates scroll button styling and icon sizing behavior. |
| web/frontend/src/lib/components/ui/select/select-scroll-down-button.svelte | Updates scroll button styling and icon sizing behavior. |
| web/frontend/src/lib/components/ui/select/select-label.svelte | Updates padding for label row. |
| web/frontend/src/lib/components/ui/select/select-item.svelte | Refactors item layout + indicator rendering; updates highlight/focus classes. |
| web/frontend/src/lib/components/ui/select/select-group.svelte | Adds styling hook for group padding/scroll. |
| web/frontend/src/lib/components/ui/select/select-content.svelte | Updates content styling and viewport padding conventions. |
| web/frontend/src/lib/components/ui/scroll-area/scroll-area.svelte | Updates viewport focus ring classes. |
| web/frontend/src/lib/components/ui/scroll-area/scroll-area-scrollbar.svelte | Uses data-orientation styling and minor class updates. |
| web/frontend/src/lib/components/ui/progress/progress.svelte | Restyles progress root/indicator dimensions. |
| web/frontend/src/lib/components/ui/popover/popover-title.svelte | New popover title subcomponent. |
| web/frontend/src/lib/components/ui/popover/popover-header.svelte | New popover header subcomponent. |
| web/frontend/src/lib/components/ui/popover/popover-description.svelte | New popover description subcomponent. |
| web/frontend/src/lib/components/ui/popover/popover-content.svelte | Updates popover content styling to new data-open/closed conventions. |
| web/frontend/src/lib/components/ui/popover/index.ts | Exports new popover subcomponents. |
| web/frontend/src/lib/components/ui/pagination/pagination.svelte | New pagination root wrapper around bits-ui pagination. |
| web/frontend/src/lib/components/ui/pagination/pagination-previous.svelte | New “Previous” button component with icon-spacing convention. |
| web/frontend/src/lib/components/ui/pagination/pagination-prev-button.svelte | Keeps legacy prev button component (marked old). |
| web/frontend/src/lib/components/ui/pagination/pagination-next.svelte | New “Next” button component with icon-spacing convention. |
| web/frontend/src/lib/components/ui/pagination/pagination-next-button.svelte | Keeps legacy next button component (marked old). |
| web/frontend/src/lib/components/ui/pagination/pagination-link.svelte | New page link component with active state. |
| web/frontend/src/lib/components/ui/pagination/pagination-item.svelte | New pagination list item wrapper. |
| web/frontend/src/lib/components/ui/pagination/pagination-ellipsis.svelte | New ellipsis component for truncated pages. |
| web/frontend/src/lib/components/ui/pagination/pagination-content.svelte | New pagination list container component. |
| web/frontend/src/lib/components/ui/pagination/index.ts | Exports pagination primitives (including legacy aliases). |
| web/frontend/src/lib/components/ui/label/label.svelte | Minor class ordering / disabled handling tweaks. |
| web/frontend/src/lib/components/ui/input/input.svelte | Major input styling refresh consistent with new design system. |
| web/frontend/src/lib/components/ui/input-group/input-group.svelte | New input group wrapper component. |
| web/frontend/src/lib/components/ui/input-group/input-group-textarea.svelte | New textarea control wrapper for input group. |
| web/frontend/src/lib/components/ui/input-group/input-group-text.svelte | New text addon component for input group. |
| web/frontend/src/lib/components/ui/input-group/input-group-input.svelte | New input control wrapper for input group. |
| web/frontend/src/lib/components/ui/input-group/input-group-button.svelte | New button wrapper with size variants for input group. |
| web/frontend/src/lib/components/ui/input-group/input-group-addon.svelte | New addon wrapper with click-to-focus behavior. |
| web/frontend/src/lib/components/ui/input-group/index.ts | Exports input-group components. |
| web/frontend/src/lib/components/ui/empty/empty.svelte | Updates empty state container styling. |
| web/frontend/src/lib/components/ui/empty/empty-title.svelte | Updates empty title typography. |
| web/frontend/src/lib/components/ui/empty/empty-media.svelte | Adjusts icon media sizing rules. |
| web/frontend/src/lib/components/ui/empty/empty-header.svelte | Minor class ordering tweaks. |
| web/frontend/src/lib/components/ui/empty/empty-description.svelte | Adjusts empty description styling (contains duplication). |
| web/frontend/src/lib/components/ui/empty/empty-content.svelte | Updates empty content spacing. |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-sub-trigger.svelte | Updates trigger styling and chevron spacing. |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-sub-content.svelte | Updates submenu content styling. |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-shortcut.svelte | Updates shortcut styling (focus state coloring). |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-radio-item.svelte | Updates indicator icon and item layout conventions. |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-label.svelte | Adjusts label typography and padding. |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-item.svelte | Updates item focus/disabled/variant styling conventions. |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-content.svelte | Adds align prop passthrough and updates content styling. |
| web/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-checkbox-item.svelte | Updates indicator placement and focus/disabled styling. |
| web/frontend/src/lib/components/ui/drawer/drawer-title.svelte | Updates title typography. |
| web/frontend/src/lib/components/ui/drawer/drawer-overlay.svelte | Updates overlay styling. |
| web/frontend/src/lib/components/ui/drawer/drawer-header.svelte | Updates header spacing and responsive alignment behavior. |
| web/frontend/src/lib/components/ui/drawer/drawer-footer.svelte | Updates footer spacing. |
| web/frontend/src/lib/components/ui/drawer/drawer-content.svelte | Updates drawer content styling and handle styling. |
| web/frontend/src/lib/components/ui/dialog/dialog-trigger.svelte | Adds default type="button" to trigger. |
| web/frontend/src/lib/components/ui/dialog/dialog-title.svelte | Updates dialog title typography. |
| web/frontend/src/lib/components/ui/dialog/dialog-overlay.svelte | Updates overlay styling and data-open/closed conventions. |
| web/frontend/src/lib/components/ui/dialog/dialog-header.svelte | Updates header layout classes. |
| web/frontend/src/lib/components/ui/dialog/dialog-footer.svelte | Adds optional footer close button and restyles footer container. |
| web/frontend/src/lib/components/ui/dialog/dialog-description.svelte | Adds link styling within description. |
| web/frontend/src/lib/components/ui/dialog/dialog-content.svelte | Restyles content and reimplements close button via Button. |
| web/frontend/src/lib/components/ui/dialog/dialog-close.svelte | Adds default type="button" to close. |
| web/frontend/src/lib/components/ui/command/command.svelte | Restyles command container. |
| web/frontend/src/lib/components/ui/command/command-shortcut.svelte | Updates shortcut focus/selected styling. |
| web/frontend/src/lib/components/ui/command/command-list.svelte | Adds no-scrollbar and updates list sizing. |
| web/frontend/src/lib/components/ui/command/command-item.svelte | Converts item to slotful component and adds a check indicator icon. |
| web/frontend/src/lib/components/ui/command/command-input.svelte | Rebuilds command input using new InputGroup components. |
| web/frontend/src/lib/components/ui/command/command-group.svelte | Updates group heading styling hooks. |
| web/frontend/src/lib/components/ui/command/command-dialog.svelte | Adds class + showCloseButton plumbing; updates defaults and styling. |
| web/frontend/src/lib/components/ui/checkbox/checkbox.svelte | Updates checkbox styling and indicator rendering. |
| web/frontend/src/lib/components/ui/card/card.svelte | Adds size prop and updates base card styling. |
| web/frontend/src/lib/components/ui/card/card-title.svelte | Updates title typography and size responsiveness. |
| web/frontend/src/lib/components/ui/card/card-header.svelte | Updates header padding and layout rules. |
| web/frontend/src/lib/components/ui/card/card-footer.svelte | Updates footer container styling. |
| web/frontend/src/lib/components/ui/card/card-content.svelte | Updates content padding and spacing. |
| web/frontend/src/lib/components/ui/card/card-action.svelte | Adds a marker class and updates action layout. |
| web/frontend/src/lib/components/ui/button/button.svelte | Major button variant/size/style changes to new design system baseline. |
| web/frontend/src/lib/components/ui/breadcrumb/breadcrumb.svelte | Adds cn() and a marker class for breadcrumb root. |
| web/frontend/src/lib/components/ui/breadcrumb/breadcrumb-separator.svelte | Import reordering only. |
| web/frontend/src/lib/components/ui/breadcrumb/breadcrumb-list.svelte | Updates breadcrumb list styling (includes invalid class issue). |
| web/frontend/src/lib/components/ui/breadcrumb/breadcrumb-item.svelte | Minor class ordering changes. |
| web/frontend/src/lib/components/ui/breadcrumb/breadcrumb-ellipsis.svelte | Updates ellipsis icon and sizing. |
| web/frontend/src/lib/components/ui/badge/badge.svelte | Major badge variants/style updates and adds new variants. |
| web/frontend/src/lib/components/ui/avatar/index.ts | Exports new avatar subcomponents (badge/group/count). |
| web/frontend/src/lib/components/ui/avatar/avatar.svelte | Adds size prop and updates base avatar styling. |
| web/frontend/src/lib/components/ui/avatar/avatar-image.svelte | Ensures image is object-cover and rounded. |
| web/frontend/src/lib/components/ui/avatar/avatar-group.svelte | New avatar group component. |
| web/frontend/src/lib/components/ui/avatar/avatar-group-count.svelte | New avatar group count component. |
| web/frontend/src/lib/components/ui/avatar/avatar-fallback.svelte | Updates fallback styling + size responsiveness. |
| web/frontend/src/lib/components/ui/avatar/avatar-badge.svelte | New avatar badge component. |
| web/frontend/src/lib/components/ui/alert/index.ts | Exports new alert action component. |
| web/frontend/src/lib/components/ui/alert/alert.svelte | Updates alert base/variant styles. |
| web/frontend/src/lib/components/ui/alert/alert-title.svelte | Updates title/link styling. |
| web/frontend/src/lib/components/ui/alert/alert-description.svelte | Updates description spacing + link styling. |
| web/frontend/src/lib/components/ui/alert/alert-action.svelte | New alert action positioning wrapper. |
| web/frontend/src/lib/components/SchemaForm.svelte | Minor formatting plus icon migration to data-icon. |
| web/frontend/src/lib/components/ScenarioEditor.svelte | Formatting + icon migration; minor markup adjustments. |
| web/frontend/src/lib/components/RecentScenariosSection.svelte | Formatting change for badge markup. |
| web/frontend/src/lib/components/PackSimulationsSheet.svelte | Formatting change for back button markup. |
| web/frontend/src/lib/components/PackCard.svelte | Formatting changes (one odd linebreak in closing tag). |
| web/frontend/src/lib/components/NewScenarioDialog.svelte | Formats long description line. |
| web/frontend/src/lib/components/NewAssessmentDialog.svelte | Removes blank line; wraps long explanatory text. |
| web/frontend/src/lib/components/ExpectationRow.svelte | Migrates combobox icon spacing to data-icon. |
| web/frontend/src/lib/components/connectors/GCPConnectorForm.svelte | Formatting: collapses helper text to single line. |
| web/frontend/src/lib/components/connectors/ElasticConnectorForm.svelte | Formatting tweaks; minor markup simplification. |
| web/frontend/src/lib/components/connectors/ConnectorDetail.svelte | Formatting and long-line wrapping; minor sheet root formatting. |
| web/frontend/src/lib/components/connectors/AzureConnectorForm.svelte | Simplifies boolean return formatting. |
| web/frontend/src/lib/components/connectors/AWSConnectorForm.svelte | Formatting: collapses helper text to single line. |
| web/frontend/src/app.css | Imports shadcn-svelte + tw-animate CSS; removes local custom-variant/util definitions now provided externally. |
| web/frontend/package.json | Adds shadcn-svelte + tw-animate-css; bumps lucide; loosens vaul-svelte version. |
| web/frontend/package-lock.json | Lockfile updates for new deps and version bumps. |
| openspec/specs/frontend-design-system/spec.md | New design system specification documenting registry style + icon convention. |
| openspec/specs/connectors/spec.md | Adds requirement for UI–backend connector type parity. |
| openspec/specs/assessment-retention/spec.md | Adds assessment retention specification. |
| openspec/changes/live-scenario-detail/tasks.md | Task tracking for live scenario detail work. |
| openspec/changes/live-scenario-detail/specs/runs/spec.md | Spec updates for scenario result lifecycle (identity/assertions mid-run). |
| openspec/changes/live-scenario-detail/proposal.md | Proposal for live scenario detail persistence. |
| openspec/changes/live-scenario-detail/design.md | Design doc for mid-run scenario identity/assertion persistence. |
| openspec/changes/live-scenario-detail/.openspec.yaml | OpenSpec metadata for change. |
| openspec/changes/archive/2026-06-23-split-connectors-page/specs/connectors/spec.md | Archive: connector parity requirement. |
| openspec/changes/archive/2026-06-23-split-connectors-page/proposal.md | Archive: connectors page split proposal. |
| openspec/changes/archive/2026-06-23-split-connectors-page/.openspec.yaml | Archive metadata. |
| openspec/changes/archive/2026-06-23-migrate-shadcn-svelte-style/tasks.md | Archive: shadcn style migration tasks. |
| openspec/changes/archive/2026-06-23-migrate-shadcn-svelte-style/specs/frontend-design-system/spec.md | Archive: design-system requirement. |
| openspec/changes/archive/2026-06-23-migrate-shadcn-svelte-style/proposal.md | Archive: shadcn style migration proposal. |
| openspec/changes/archive/2026-06-23-migrate-shadcn-svelte-style/design.md | Archive: shadcn style migration design. |
| openspec/changes/archive/2026-06-23-migrate-shadcn-svelte-style/.openspec.yaml | Archive metadata. |
| openspec/changes/archive/2026-06-23-assessment-retention/tasks.md | Archive: assessment retention tasks. |
| openspec/changes/archive/2026-06-23-assessment-retention/specs/runs/spec.md | Archive: run deletion behavior spec update. |
| openspec/changes/archive/2026-06-23-assessment-retention/specs/assessment-retention/spec.md | Archive: assessment retention requirements. |
| openspec/changes/archive/2026-06-23-assessment-retention/proposal.md | Archive: assessment retention proposal. |
| openspec/changes/archive/2026-06-23-assessment-retention/.openspec.yaml | Archive metadata. |
| internal/web/scenarios.go | Wires new runner callbacks to DB updates for identity/assertions mid-run. |
| internal/web/scenario_results.go | Adds partial assertion DTO + JSON marshalling helper. |
| internal/testutil/fakes/fakes.go | Extends fake RunStore with partial update methods. |
| internal/testutil/fakes/fakes_test.go | Adds contract test for partial scenario updates preserving status/phase. |
| internal/runner/scenario.go | Adds callback hooks + value types for identity/assertion progress. |
| internal/runner/runner.go | Emits identity once post-detonation and assertion snapshots on each new match. |
| internal/runner/runner_test.go | Adds tests for callback firing semantics and tri-state assertion snapshots. |
| internal/db/runs.go | Adds RunStore interface + SQL updates for scenario identity/assertions. |
| .claude/skills/shadcn-svelte/rules/styling.md | Adds styling/customization rules for the design system. |
| .claude/skills/shadcn-svelte/rules/icons.md | Adds icon usage rules (data-icon convention, no manual sizing). |
Files not reviewed (1)
- web/frontend/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| data-slot="breadcrumb-list" | ||
| class={cn( | ||
| 'text-muted-foreground flex flex-wrap items-center gap-1.5 text-sm break-words sm:gap-2.5', | ||
| 'text-muted-foreground gap-1.5 text-sm flex flex-wrap items-center wrap-break-word', |
Comment on lines
31
to
33
| <div | ||
| class="bg-muted mx-auto mt-4 hidden h-2 w-[100px] shrink-0 rounded-full group-data-[vaul-drawer-direction=bottom]/drawer-content:block" | ||
| class="bg-muted mx-auto mt-4 hidden h-1 w-[100px] shrink-0 rounded-full group-data-[vaul-drawer-direction=bottom]/drawer-content:block bg-muted mx-auto hidden shrink-0 group-data-[vaul-drawer-direction=bottom]/drawer-content:block" | ||
| ></div> |
Comment on lines
99
to
106
| executionOutput["simulation_id"] = scenario.Detonator.SimulationId() | ||
| } | ||
|
|
||
| // Surface executor identity now that detonation has resolved execution_id / | ||
| // simulation_id, so a still-running row shows what is executing and where. | ||
| reportIdentity(scenario, executionId) | ||
|
|
||
| // If no assertions, no collector, and not explore mode, just return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revamps the assessment and rule-coverage pages, completes the migration of the shadcn-svelte component library to the nova style, and adds live mid-run detail to scenario results. Also ships a
shadcn-svelteagent skill and archives the completed OpenSpec changes.UI / Pages
assessments/[runId]).Badgesuccessvariant.Design-system migration (shadcn-svelte → nova)
ui/*components from the nova registry style.app.css: importtw-animate-css+shadcn-svelte/tailwind.css, dropping hand-maintained duplicates (data-* variants, no-scrollbar, accordion keyframes).data-icon="inline-start|inline-end"convention for icons insideButton/DropdownMenu.Item; bumped@lucide/svelteto^1.21.Live scenario detail (runner → UI)
IdentityCallback/AssertionsCallbacksurface executor identity (after detonation) and incremental assertion results (during matching) on a still-runningscenario_resultsrow.UpdateScenarioIdentity/UpdateScenarioAssertions; the frontend renders identity and a tri-state assertion bar (passed / failed / pending) on running rows.Tooling & docs
shadcn-svelteskill (.claude/skills/shadcn-svelte/) — CLI reference, composition/forms/icons/styling rules, customization guide.