fix(thermoelastic2d): fix Config nelx/nely ClassVar issue

[mkeeler43]

Summary

• Change nelx and nely from ClassVar to regular dataclass fields in thermoelastic2d's Config, matching the pattern used by beams2d. This fixes a TypeError when check_constraints calls rmin_bound, which requires nelx and nely as parameters but couldn't find them in dataclasses.asdict() output.
• Fix nely being incorrectly assigned NELX instead of NELY.
• Bump Hugging Face dataset version from v0 to v1.

Test plan

• Verify check_constraints no longer raises TypeError for thermoelastic2d configs
• Verify dataclasses.asdict(Config()) includes nelx and nely
• Run existing thermoelastic2d tests

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes thermoelastic2d configuration serialization so constraint checking can access nelx/nely, corrects a nely default typo, and updates the Hugging Face dataset identifier.

Changes:

• Convert ThermoElastic2D.Config.nelx/nely from ClassVar to dataclass fields so they appear in dataclasses.asdict().
• Fix nely default to use NELY (was incorrectly set to NELX).
• Bump dataset_id from IDEALLab/thermoelastic_2d_v0 to IDEALLab/thermoelastic_2d_v1.

Comments suppressed due to low confidence (1)

engibench/problems/thermoelastic2d/v0.py:95

• The regression being fixed here (TypeError in check_constraints because nelx/nely were ClassVar and excluded from dataclasses.asdict()) isn’t covered by a test. Add a small unit/integration test that instantiates ThermoElastic2D, calls check_constraints with a valid design/config, and asserts it does not raise (and/or that dataclasses.asdict(ThermoElastic2D.Config()) includes nelx and nely) to prevent this from reappearing.

        nelx: Annotated[int, bounded(lower=1).category(THEORY)] = NELX
        nely: Annotated[int, bounded(lower=1).category(THEORY)] = NELY
        max_iter: int = fea_model.MAX_ITERATIONS
        """Maximal number of iterations for optimize."""

        @constraint
        @staticmethod
        def rmin_bound(rmin: float, nelx: int, nely: int) -> None:
            """Constraint for rmin ∈ (0.0, max{ nelx, nely }]."""
            assert 0.0 < rmin <= max(nelx, nely), f"Params.rmin: {rmin} ∉ (0, max(nelx, nely)]"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.