Variability: Simplify implementation of skeleton tree graph creation class#1646
Merged
kbirken merged 1 commit intomaintenance/mps20241from Feb 23, 2026
Merged
Conversation
kbirken
force-pushed
the
feature/simplify_skeltree_graph_builder_1645
branch
from
327cbe9 to
de543ee
Compare
dbinkele
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the code of the class which creates graphviz diagrams from skeleton trees.
I also replaced the "diamond" shape by the "hexagon" shape as it wastes less space, which is especially helpful if the graphs are big.
This solves #1645.