Skip to content

Conversation

@rolker
Copy link

@rolker rolker commented Nov 20, 2025

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@rolker
Copy link
Author

rolker commented Nov 20, 2025

This allows #35 to work

@woensug-choi
Copy link

@hmoyen I was trying demo launches on this PR to approve. But some worlds and models in Gazebo Community Meeting (Nov, 26) slides didn't work (not included in ROS2 branch, e.g. dave_ocean_waves_sonar_integrated) I guess this PR is good to go once all below demo launches work without any problem.

  • ros2 launch dave_multibeam_sonar_demo multibeam_sonar_demo.launch.py
  • ros2 launch dave_demos dave_sensor.launch.py namespace:=blueview_p900 world_name:=dave_ocean_waves_sonar_integrated paused:=false x:=22.5 y:=-4 z:=-15 pitch:=0.2 yaw:=3.14
  • ros2 launch dave_demos dave_robot.launch.py z:=-10 x:=5 namespace:=bluerov2_heavy world_name:=dave_ocean_waves_sonar paused:=false

@hmoyen
Copy link
Collaborator

hmoyen commented Nov 26, 2025

@hmoyen I was trying demo launches on this PR to approve. But some worlds and models in Gazebo Community Meeting (Nov, 26) slides didn't work (not included in ROS2 branch, e.g. dave_ocean_waves_sonar_integrated) I guess this PR is good to go once all below demo launches work without any problem.

* [x]  ros2 launch dave_multibeam_sonar_demo multibeam_sonar_demo.launch.py

* [ ]  ros2 launch dave_demos dave_sensor.launch.py namespace:=blueview_p900 world_name:=dave_ocean_waves_sonar_integrated paused:=false x:=22.5 y:=-4 z:=-15 pitch:=0.2 yaw:=3.14

* [ ]  ros2 launch dave_demos dave_robot.launch.py z:=-10 x:=5 namespace:=bluerov2_heavy world_name:=dave_ocean_waves_sonar paused:=false

Hey! I pulled the branch and the demos seem to be working for me (as long as they are included in the models folder, like in the sonar-demo branch). What error did you encounter?

@woensug-choi
Copy link

@hmoyen Just didn't know where to find those model files. I see them at sonar-demo :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants