Update according to latest version of py2hwsw#23
Closed
arturum1 wants to merge 2 commits intoIObundle:mainfrom
Closed
Update according to latest version of py2hwsw#23arturum1 wants to merge 2 commits intoIObundle:mainfrom
arturum1 wants to merge 2 commits intoIObundle:mainfrom
Conversation
jjts
requested review from
P-Miranda and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to align with the latest version of py2hwsw, making several formatting and naming consistency changes.
- Replace single quotes with double quotes for Python dictionary access
- Update macro name from
_SWREG_ADDR_Wto_CSRS_ADDR_W - Reformat multi-line string expressions for better readability
Comment on lines
+71
to
72
| fswhdr.write(f"#define {core_prefix}_CSRS_ADDR_W {mkregs_obj.core_addr_w}\n\n") | ||
|
|
There was a problem hiding this comment.
The macro name change from _SWREG_ADDR_W to _CSRS_ADDR_W could be a breaking change for existing code that depends on this header file. Ensure that all consumers of this generated header are updated to use the new macro name.
Suggested change
| fswhdr.write(f"#define {core_prefix}_CSRS_ADDR_W {mkregs_obj.core_addr_w}\n\n") | |
| fswhdr.write(f"#define {core_prefix}_CSRS_ADDR_W {mkregs_obj.core_addr_w}\n") | |
| fswhdr.write(f"#define {core_prefix}_SWREG_ADDR_W {core_prefix}_CSRS_ADDR_W\n\n") |
Contributor
Author
|
Changes included in #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR IObundle/py2hwsw#379