fix jsf guestbook response cancel button#12220
Open
stevenwinship wants to merge 2 commits intodevelopfrom
Open
fix jsf guestbook response cancel button#12220stevenwinship wants to merge 2 commits intodevelopfrom
stevenwinship wants to merge 2 commits intodevelopfrom
Conversation
github-actions
bot
added
Size: 10
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
bea3745 to
8e41494
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
8e41494 to
f30e3dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Pressing 'Cancel' button on JSF Guestbook Response screen (preview, download, or request access) does not cancel the dialog
Which issue(s) this PR closes:#12205
Special notes for your reviewer: lines prior to 291 are just reformatted because the spacing was off. No code changes were made. The new code comes after line 291
Suggestions on how to test this: Make a dataset require a guestbook response. Try to preview the file. Try to download the file. Also with dataverse.files.guestbook-at-request=true try to request access to a restricted file. Old version - cancel does nothing. This version - Cancel closes the tab/dialog and returns you to the files tab.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: