Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: COAR originally used a purl URL in it's examples for the COAR notify context used in it's JSON-LD messages. With purl down today, I noticed because the tests slow down by minutes as they wait for purl.org to timeout. (As there has been some flakiness before, the main code has a fallback if retrieving the context fail, but it still waits).
This PR updates the test messages we create to use the more direct https://coar-notify.net URL COAR now shows in it's online examples.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Verify tests still work. If purl.org is down when testing, you may see the test run slow before and fast after the PR. I did see this at QDR while purl.org was down:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: