New ADC implementation #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkarpov-ui
assigned
mpkarpov-ui,
Shoeyoung4 and
alyssa-loverde and unassigned
mpkarpov-ui
mpkarpov-ui
requested changes
Feb 11, 2026
Contributor
mpkarpov-ui
left a comment
mpkarpov-ui
left a comment
There was a problem hiding this comment.
I think this is mostly good, only requesting changes for some of the magic number stuff in my comments. Will approve after that :)
Overall great work though, looks functionally good & I witnessed it working as well,
Comment on lines
+83
to
+84
| float A_value = sensorA.value* (100000.0/118000); //accounting for the resisters | ||
| float A_voltage = (((float)A_value / 65535) * 3.3)/(18.0/100); |
Contributor
There was a problem hiding this comment.
I would love maybe to move some of these numbers to defines or something, it does look like some "magic math" is happening here...
| @@ -1,4 +1,4 @@ | |||
| #include "silsim/emulation.h" | |||
| //#include "silsim/emulation.h" | |||
Contributor
There was a problem hiding this comment.
very curious change, but i care more about it compiling on FSW than working on SILSIM.
Contributor
There was a problem hiding this comment.
We will probably do hilsim updates post luna or whatever, so dont worry abt silsim stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We created a new implementation of checking continuity to the voltage struct and deleted the continuity struct.