-
Notifications
You must be signed in to change notification settings - Fork 32
✅ Add e2e tests for metamodeling #8457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
✅ Add e2e tests for metamodeling #8457
Conversation
Signed-off-by: Alejandro Parcet <parcet@speag.com>
Signed-off-by: Alejandro Parcet <parcet@speag.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8457 +/- ##
==========================================
+ Coverage 87.13% 88.72% +1.58%
==========================================
Files 2010 1802 -208
Lines 79007 71413 -7594
Branches 1377 863 -514
==========================================
- Hits 68844 63359 -5485
+ Misses 9764 7835 -1929
+ Partials 399 219 -180
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
We usually like to include a bit more context to help us track changes, connect related issues, and coordinate work more easily. It shouldn’t take much time.
A few suggestions:
- Assign yourself to the issue (I went ahead and did that for you this time).
- Add the relevant project and labels.
- Include a short description — you can even use AI for that — and fill out the PR template sections where applicable (e.g. enumerate related PO issues )
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Alejandro Parcet <parcet@speag.com>
…lexpargon/osparc-simcore into add-e2e-tests-for-metamodeling
…hboard each time Signed-off-by: Alejandro Parcet <parcet@speag.com>
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, there are a few things I would suggest:
- no need to wait so much everywhere with timeouts in the production test (it shall run as fast as possible) if there is no functional need (click already has an integrated 30 seconds default timeout)
mmux-testidthis is very nice! please check the locations where you do not use it as this is fragile and will for sure break as soon as you modify the UI- ideally after the test everything should be deleted and cleaned so we do not accumulate e2e data (and actually pay for it)
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Show resolved
Hide resolved
|
Signed-off-by: Alejandro Parcet <parcet@speag.com>
Signed-off-by: Alejandro Parcet <parcet@speag.com>
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
tests/e2e-playwright/tests/metamodeling/test_response_surface_modeling.py
Outdated
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Signed-off-by: Alejandro Parcet <parcet@speag.com>
Signed-off-by: Alejandro Parcet <parcet@speag.com>
|



What do these changes do?
Added test for the Meta Modeling services:
to this end,
mmux-testids where added to the meta modeling service.Related issue/s
How to test
The changes include a new test phase which executes e2e playwright tests on the osparc service, by creating a project with JSONIFIER, creating a function from this proyect, and then launching MMuX to populate the function with jobs and use them to test each of the tools MMuX enables
Dev-ops