Add Prometheus impl of RabbitMQ MetricsCollector#78
Open
alexcardell wants to merge 4 commits intoITV:masterfrom
Open
Add Prometheus impl of RabbitMQ MetricsCollector#78alexcardell wants to merge 4 commits intoITV:masterfrom
alexcardell wants to merge 4 commits intoITV:masterfrom
Conversation
alexcardell
force-pushed
the
prometheus
branch
from
d002ace to
6d631c3
Compare
alexcardell
changed the title
alexcardell
force-pushed
the
prometheus
branch
from
db5e38f to
e475335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a Prometheus implementation of
MetricsCollectorThis only does counts without labels due to the limitations of the interface
Extra
We can add a middleware similar to the Kamon module, for labelling metrics by queue, etc. However, I think do this in a separate PR (I'm leaning towards Epimetheus for this for effectful metrics)