Allow OrderedList to be initialized with an existing NodeCache#1
Open
aploshay wants to merge 1 commit intov11.0.0.rc7from
Open
Allow OrderedList to be initialized with an existing NodeCache#1aploshay wants to merge 1 commit intov11.0.0.rc7from
aploshay wants to merge 1 commit intov11.0.0.rc7from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code seems a bit odd in that:
node_cacheonly hasaccessor(read-only) ability, and only privatelySo it seems like there was meant to be some way to pass in an initial value, but this wasn't fully implemented? In any case, we need that ability in pumpkin, and this provides it.
This change has already been pushed to the
v11.0.0.rc8branch of our fork, so that pumpkin pull request pumpkin pull request #186 can make use of it. This PR exists to facilitate review and discussion.Note that the code for current active-fedora still contains the same initialization pattern (nil guard, with no way to pass a value) for
@node_cache. Even if we're violating intended use ofOrderedListby using it in a nested fashion, I'm still scratching my head over this setup.