fix: use correct data source for outgoing connections #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatConnections function was incorrectly iterating over incomingConnections when formatting outgoing connections, causing the getModelObjectRelationships tool to return wrong data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
formatConnectionswhere outgoing connections were iterating overincomingConnectionsinstead ofoutgoingConnections.Problem
The
getModelObjectRelationshipstool was returning incorrect data for outgoing connections. When a user queried "what does Service A connect to?", they would see incoming connections mislabeled as outgoing.Solution
Changed line 236 in
src/format.tsfrom:Verified the fix by calling
getModelObjectRelationshipsand confirming outgoing connections now display the correct source/target relationships.