Conversation
Al2Klimov
requested changes
Mar 24, 2026
THIRD_PARTY_LICENSES.md
Outdated
| ## License Summary | ||
|
|
||
| | License | Component | License Files / Notes | | ||
| |-------------------|-----------------------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| |
Member
There was a problem hiding this comment.
The poor guy who'll have to maintain this table over time...
Seriously speaking, are you ten billion percent sure reviewers of dependabot PRs will make sure this table is up to date?
If not, I'd do either of the following:
- Add a GitHub action which automatically comments on newly opened dependabot PRs, telling reviewers to keep this in mind
- Omit this table – shipped license files of the individual projects are there after all
Member
Author
There was a problem hiding this comment.
GitHub Actions is a topic for later. Licenses must be displayed, and users should not be required to gather them on their own.
Rename the license file to `LICENSE.md`, switch to a Markdown heading, and normalize the Icinga URL. This aligns the license file with the repository's Markdown-based documentation and establishes `LICENSE.md` as a consistent convention across all Icinga repositories.
Adjust the package-wide MIT claim from `composer.json`, scope MIT to Icinga-authored glue in `LICENSE.md`, add `THIRD_PARTY_LICENSES.md`, and update the README to reflect the package's mixed licensing.
Al2Klimov
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package bundles third-party components under multiple upstream
licenses rather than a single package-wide MIT license.
licenseentry incomposer.json.LICENSE.md.THIRD_PARTY_LICENSES.mdfor non-MIT bundled components and assets.README.mdwording with the new licensing layout.