Skip to content

Correct Icinga\Application\Web doc comment#5466

Closed
Al2Klimov wants to merge 1 commit intomainfrom
Web-vs-EmbeddedWeb
Closed

Correct Icinga\Application\Web doc comment#5466
Al2Klimov wants to merge 1 commit intomainfrom
Web-vs-EmbeddedWeb

Conversation

@Al2Klimov
Copy link
Copy Markdown
Member

In contrast to EmbeddedWeb, Web is specifically for Icinga Web itself, no "other web projects".

In contrast to EmbeddedWeb, Web is specifically for Icinga Web itself, no "other web projects".
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the documentation comment for the Icinga\Application\Web class to accurately reflect that it is specifically for Icinga Web itself, not for other web projects (which is what EmbeddedWeb is for).

Changes:

  • Updated the class-level doc comment to clarify that the Web class is for Icinga Web itself, distinguishing it from EmbeddedWeb which is for other web projects

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lippserd
Copy link
Copy Markdown
Member

lippserd commented Mar 3, 2026

I would prefer to replace the entire description, as both sentences really don't say anything. Since this is a very low priority, I will simply close the PR.

@lippserd lippserd closed this Mar 3, 2026
@lippserd lippserd deleted the Web-vs-EmbeddedWeb branch March 3, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants