Add strict types to GettextTranslator and NoopTranslator#13
Merged
Conversation
nilmerg
force-pushed
the
strict-interfaces
branch
from
44f3191 to
e59c279
Compare
lippserd
force-pushed
the
strict-interfaces
branch
from
e59c279 to
013105a
Compare
lippserd
changed the title
GettextTranslator and NoopTranslator
lippserd
force-pushed
the
strict-interfaces
branch
2 times, most recently
from
b730d78 to
2f9ea23
Compare
lippserd
force-pushed
the
strict-interfaces
branch
from
2f9ea23 to
f857603
Compare
`ipl-stdlib` introduces strict type declarations, requiring all classes implementing its interfaces to match the exact parameter and return types defined there. Updated affected classes and bumped the required `ipl-stdlib` and PHP version in `composer.json` accordingly. Co-authored-by: Bastian Lederer <bastian.lederer@icinga.com> Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
lippserd
force-pushed
the
strict-interfaces
branch
from
f857603 to
b1526fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipl-stdlibintroduces strict type declarations, requiring all classesimplementing its interfaces to match the exact parameter and return types
defined there. Updated affected classes accordingly.
ipl-stdlibversion bump incomposer.json