Merged
Conversation
Potential bugfix releases for maintained older versions should receive the same PHP checks as the default branch. Extend push builds to also cover `support/*` and drop the pull request target filter so validation still runs for pull requests merged through other pull requests. Enable `workflow_dispatch` for ad-hoc verification.
Enable Composer's `sort-packages` setting and run `composer normalize` to establish a consistent structure for `composer.json`. This keeps future dependency changes deterministic and reduces unnecessary diff noise.
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
5 times, most recently
from
bc6d54a to
3752200
Compare
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
from
3752200 to
d7a91ca
Compare
sukhwinder33445
previously approved these changes
Mar 18, 2026
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
from
d7a91ca to
08699bf
Compare
Member
Author
|
@sukhwinder33445 I'm sorry I pushed again after you reviewed it, but I made a few more changes that should be in this PR. Those are about cleaning up inline comments and tightening wording, and replacing fenced code examples with indented blocks for better IDE rendering. |
sukhwinder33445
previously approved these changes
Mar 19, 2026
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
4 times, most recently
from
a8b2b17 to
33f0466
Compare
Add a minimal `.gitattributes` file so `git archive` excludes CI and Git configuration files as well as test-related files. This keeps release archives focused on the package contents.
Remove the broad hidden file exclusion and its `.git*` whitelist in
favor of a global `~/.gitignore`. Editor and OS artifacts such as
`.DS_Store`, `.idea/`, or `.vscode/` are environment-specific and not
the project's responsibility to exclude.
Each developer should maintain a global ignore file for such artifacts:
git config --global core.excludesFile ~/.gitignore
Keep only Composer installation artifacts with a comment clarifying
why `composer.lock` is excluded for library projects.
Rename the license file to `LICENSE.md`, switch to a Markdown heading, and normalize the Icinga URL. This aligns the license file with the repository's Markdown-based documentation and establishes `LICENSE.md` as a consistent convention across all Icinga repositories.
Introduced changelog covers all releases and unreleased changes, derived from tags, release notes, commits, and related pull requests.
Add a package overview, installation requirements, and focused examples for standalone validators and validator chains. This gives users practical guidance without turning the README into a validator-by-validator reference.
Standardize class-level docblocks to use the imperative mood and add missing docblocks to `isValid()` and other undocumented methods. Correct two inaccuracies in `EmailAddressValidator` and `StringLengthValidator`. Replace fenced code examples with indented blocks for better IDE rendering.
Inline comments should read as complete sentences and be easy to scan. Ending each comment with a full stop signals that the thought is complete and keeps the style consistent across the codebase. Where comments were verbose or imprecise, take the opportunity to tighten the wording without changing meaning.
All affected throw sites represent invalid caller-supplied configuration, e.g., missing required options or a min value that exceeds max. Replacing the generic `Exception` and `LogicException` with `InvalidArgumentException` communicates that intent precisely. `InvalidArgumentException` is a subclass of `LogicException`, so existing catch blocks continue to work without modification.
lippserd
force-pushed
the
docs-and-repo-housekeeping
branch
from
33f0466 to
c2308b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates several maintenance tasks to bring the repository
in line with shared conventions across our projects.
CI
support/*and trigger validation for all pullrequests regardless of target branch
workflow_dispatchfor ad-hoc verificationRepository
.gitattributesto exclude CI, Git configuration, andtest-related files from
git archiveoutputssort-packagessetting and normalizecomposer.jsonLICENSE.mdto align with the repository'sMarkdown-based documentation and establish a consistent convention
across all repositories
Documentation
CHANGELOG.mdto summarize notable changes per releaseREADME.mdwith a package overview, installation requirements,and focused examples for standalone validators and validator chains
InvalidArgumentException