fix: Fixed two things when updating the demo app#162
Open
JacquesDIconica wants to merge 4 commits intomasterfrom
Open
fix: Fixed two things when updating the demo app#162JacquesDIconica wants to merge 4 commits intomasterfrom
JacquesDIconica wants to merge 4 commits intomasterfrom
Conversation
bart-iconica
requested changes
Apr 22, 2025
Contributor
bart-iconica
left a comment
bart-iconica
left a comment
There was a problem hiding this comment.
This PR does two different things so it should be two separate commits. Right now I find it hard to see which part of the code is the second change and which is just the first.
packages/firebase_chat_repository/lib/src/firebase_user_repository.dart
Outdated
Show resolved
Hide resolved
JacquesDIconica
force-pushed
the
bugfix/demo_app_fixes
branch
from
0dfc2a8 to
33d790b
Compare
Contributor
Author
|
@bart-iconica I put the two fixes in their respective commits. Good call. |
JacquesDIconica
force-pushed
the
bugfix/demo_app_fixes
branch
from
cd85e79 to
99c15db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1: Changed getAllUsersForChat to retrieve users from proper place in Firebase Firestore
2: Removed unneccesary case which threw an error